8321183: Incorrect warning from cds about the modules file#2261
8321183: Incorrect warning from cds about the modules file#2261cost0much wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
|
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Improves CDS warning message about incorrect module file size. Applies cleanly from JDK22 and no bugtail. Passes GHA. Low risk as only debug message changes: no difference in runtime behavior. |
|
@cost0much |
|
/integrate |
|
@cost0much |
|
/sponsor |
|
Going to push as commit ddda5e1.
Your commit was automatically rebased without conflicts. |
|
@phohensee @cost0much Pushed as commit ddda5e1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport. Improves CDS warning message about incorrect module file size. Passes GHA
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2261/head:pull/2261$ git checkout pull/2261Update a local copy of the PR:
$ git checkout pull/2261$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2261/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2261View PR using the GUI difftool:
$ git pr show -t 2261Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2261.diff
Using Webrev
Link to Webrev Comment