Skip to content

8321183: Incorrect warning from cds about the modules file#2261

Closed
cost0much wants to merge 2 commits intoopenjdk:masterfrom
cost0much:8321183
Closed

8321183: Incorrect warning from cds about the modules file#2261
cost0much wants to merge 2 commits intoopenjdk:masterfrom
cost0much:8321183

Conversation

@cost0much
Copy link
Contributor

@cost0much cost0much commented Sep 22, 2025

Clean backport. Improves CDS warning message about incorrect module file size. Passes GHA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321183 needs maintainer approval

Issue

  • JDK-8321183: Incorrect warning from cds about the modules file (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2261/head:pull/2261
$ git checkout pull/2261

Update a local copy of the PR:
$ git checkout pull/2261
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2261

View PR using the GUI difftool:
$ git pr show -t 2261

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2261.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2025

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321183: Incorrect warning from cds about the modules file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport fd31f6a1663de0e06accdf015a71086346aa0d98 8321183: Incorrect warning from cds about the modules file Sep 22, 2025
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 22, 2025
@cost0much cost0much marked this pull request as ready for review September 22, 2025 22:38
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2025

Webrevs

@cost0much
Copy link
Contributor Author

/approval request Improves CDS warning message about incorrect module file size. Applies cleanly from JDK22 and no bugtail. Passes GHA. Low risk as only debug message changes: no difference in runtime behavior.

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@cost0much
8321183: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 22, 2025
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 26, 2025
@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@cost0much
Your change (at version e7207bc) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

Going to push as commit ddda5e1.
Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 26, 2025
@openjdk openjdk bot closed this Sep 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 26, 2025
@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@phohensee @cost0much Pushed as commit ddda5e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cost0much cost0much deleted the 8321183 branch September 26, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants