Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Oct 1, 2025

Backporting JDK-8355333: Some Problem list entries point to non-existent / wrong files. Renames three existing tests in exclude lists (After JDK-8353958 and JDK-8328247) and removes two tests (that only run on windows). Backporting for parity with Oracle.

Note: moving to this fresh PR to apply patch cleanly (previous PR: #2277)


Progress

  • Change must not contain extraneous whitespace
  • JDK-8355333 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8355333: Some Problem list entries point to non-existent / wrong files (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2291/head:pull/2291
$ git checkout pull/2291

Update a local copy of the PR:
$ git checkout pull/2291
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2291

View PR using the GUI difftool:
$ git pr show -t 2291

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2291.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355333: Some Problem list entries point to non-existent / wrong files

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 48509ab: Merge
  • 8c322f5: 8368308: ISO 4217 Amendment 180 Update
  • 4483c44: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 32a597b36f994d6e720e0576ad110dac4a5304fe 8355333: Some Problem list entries point to non-existent / wrong files Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Oct 1, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 2, 2025
@satyenme
Copy link
Author

satyenme commented Oct 2, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 2, 2025

Going to push as commit 867b417.
Since your change was applied there have been 6 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 2, 2025
@openjdk openjdk bot closed this Oct 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 2, 2025
@openjdk
Copy link

openjdk bot commented Oct 2, 2025

@satyenme Pushed as commit 867b417.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant