8358751: C2: Recursive inlining check for compiled lambda forms is broken

[wkia]

This is backport of JDK-8358751, as it's reported jdk21 is affected.

Clean backport. Tier1 is OK.

The reproducer crashes before the fix, and OK after the fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8358751 needs maintainer approval

Issue

• JDK-8358751: C2: Recursive inlining check for compiled lambda forms is broken (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2294/head:pull/2294
$ git checkout pull/2294

Update a local copy of the PR:
$ git checkout pull/2294
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2294

View PR using the GUI difftool:
$ git pr show -t 2294

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2294.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358751: C2: Recursive inlining check for compiled lambda forms is broken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

• e4f2357: 8372348: Adjust some UL / JFR string deduplication output messages
• 6dac907: 8330016: Stress seed should be initialized for runtime stub compilation
• 422784f: 8375063: Update Libpng to 1.6.54
• ... and 71 more: https://git.openjdk.org/jdk21u-dev/compare/9a28f7e7387d1ec20cd1091cecd40d1f80ad4d6f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e32908ab)
• 00: Full (14d037bf)

[wkia]

/approval request I'd like to backport this to jdk21u-dev, as it's reported jdk21 is affected. Clean backport. Tier1 is OK. The reproducer crashes before the fix, and OK after the fix.

[openjdk]

@wkia
8358751: The approval request has been created successfully.

[GoeLin]

Please backport to 25 first. Removing label in meantime.

[GoeLin]

Hi @wkia
this fix is brand new and in a central component.
I would prefer to delay this to the next release of 21.
Do you know which change caused this issue?
Could you please link it to the JBS issue?
Thanks.

[wkia]

@GoeLin Probably it's caused by "8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods".
This issue is mentioned in JDK-8358751's comments, but I don't know why it's not linked.

[GoeLin]

Ah, 8011138 is not visible to the public, so we an not link it.
Let's wait for April, please.

[bridgekeeper]

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@wkia This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[wkia]

/open

[openjdk]

@wkia This pull request is now open

[GoeLin]

HI @wkia
Can you please merge head and rerun the GHA tests?

[wkia]

Hi @GoeLin
Done

[wkia]

/integrate

[openjdk]

@wkia
Your change (at version e32908a) is now ready to be sponsored by a Committer.

[bridgekeeper]

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[wkia]

/touch

[openjdk]

@wkia The pull request is being re-evaluated and the inactivity timeout has been reset.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit 749aaf6.
Since your change was applied there have been 79 commits pushed to the master branch:

• 1cda280: 8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor
• 2ce5030: 8356107: [java.lang] Use @requires tag instead of exiting based on os.name or separatorChar property
• 2f4c955: 8354219: Automate javax/swing/JComboBox/ComboPopupBug.java
• ... and 76 more: https://git.openjdk.org/jdk21u-dev/compare/9a28f7e7387d1ec20cd1091cecd40d1f80ad4d6f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @wkia Pushed as commit 749aaf6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.