8344577: Virtual thread tests are timing out on some macOS systems

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8344577, commit a032de29 from the openjdk/jdk repository.

The commit being backported was authored by Alan Bateman on 25 Nov 2024 and was reviewed by Jaikiran Pai.

I did a minor resolve in test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java and dropped changes to several tests which do not exist in 21.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8344143 needs maintainer approval
• JDK-8344577 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8344577: Virtual thread tests are timing out on some macOS systems (Bug - P4 - Approved)
• JDK-8344143: Test jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macosx-x64 (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2297/head:pull/2297
$ git checkout pull/2297

Update a local copy of the PR:
$ git checkout pull/2297
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2297

View PR using the GUI difftool:
$ git pr show -t 2297

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2297.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344577: Virtual thread tests are timing out on some macOS systems
8344143: Test jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on  macosx-x64

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• d3facda: 8366359: Test should throw SkippedException when there is no lpstat
• f84d769: 8354928: Clean up and open source some miscellaneous AWT tests
• 0e67988: 8354561: Open source several swing tests batch0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (ef41e434)
• 00: Full (9345ee98)

[openjdk]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

GHA failure: build failed, unrelated.
/d/a/jdk21u-dev/jdk21u-dev/make/scripts/fixpath.sh: line 427: 718 Segmentation fault "$command"

[GoeLin]

Hi
Shouldn't we first backport

8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64

8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out

[8344143: Test jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macosx-x64](https://github.com/openjdk/jdk/commit/48223f7b9c6fbaf4e6751a5b41ea9e9046a48f91)

Best regards, Goetz.

[openjdk]

@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[RealCLanger]

/issue add JDK-8344143

[openjdk]

@RealCLanger
Adding additional issue to issue list: 8344143: Test jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macosx-x64.

[RealCLanger]

Hi Shouldn't we first backport

8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64

8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out

-> these are already in 21

8344143: Test jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macosx-x64

-> ok, maybe not a bad idea. So, I inlined this into this PR as I would have had to resolve anyway. I also added the changes to test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java from JDK-8336254

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 222ada9.
Since your change was applied there have been 3 commits pushed to the master branch:

• d3facda: 8366359: Test should throw SkippedException when there is no lpstat
• f84d769: 8354928: Clean up and open source some miscellaneous AWT tests
• 0e67988: 8354561: Open source several swing tests batch0

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 222ada9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.