Skip to content

8369078: Fix faulty test conversion in IllegalCharsetName.java#2301

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-0f406c42-master
Closed

8369078: Fix faulty test conversion in IllegalCharsetName.java#2301
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-0f406c42-master

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 8, 2025

I backport this as follow up of JDK-8310049.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369078 needs maintainer approval

Issue

  • JDK-8369078: Fix faulty test conversion in IllegalCharsetName.java (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2301/head:pull/2301
$ git checkout pull/2301

Update a local copy of the PR:
$ git checkout pull/2301
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2301

View PR using the GUI difftool:
$ git pr show -t 2301

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2301.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369078: Fix faulty test conversion in IllegalCharsetName.java

Reviewed-by: jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0f406c420e35f7a4358dc99711fd23d162f21777 8369078: Fix faulty test conversion in IllegalCharsetName.java Oct 8, 2025
@openjdk
Copy link

openjdk bot commented Oct 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 8, 2025
@openjdk
Copy link

openjdk bot commented Oct 8, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 8, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 9, 2025

Hi @justin-curtis-lu
thanks for the reviews.
Will you do 25, or should I address that, too?
Thanks!

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 9, 2025
@justin-curtis-lu
Copy link
Member

Hi @GoeLin, thanks for handling this. I can address the change for 25.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 13, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2025

Going to push as commit 86ca7e9.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2025
@openjdk openjdk bot closed this Oct 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2025
@openjdk
Copy link

openjdk bot commented Oct 13, 2025

@GoeLin Pushed as commit 86ca7e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants