-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name #234
Conversation
👋 Welcome back psoujany! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
/approval |
@psoujany usage: |
@hns Could you please add jdk21 tag in the OpenJDK issue. Thank you. |
You are missing the fix-request comments. Please read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix. |
/approval request JDK21 generates docs with violations which got fixed in later release i.e 23. Hence requesting this backport which resolves couple of the violations. Risk would be moderate as this affects javadoc generation. No regressions shown in Tier1 and javadoc tests from jdk21u-dev. |
@psoujany usage: |
/approval request JDK21 generates docs with couple of violations which got fixed in later release i.e 23. Hence requesting this backport. No regressions shown in Tier1 and javadoc tests from jdk21u-dev. |
@GoeLin I've raised fix request. Thank you. |
@psoujany This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@hns) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@GoeLin Could you please sponsor this fix. Thank you. |
/sponsor |
Going to push as commit e69b611.
Your commit was automatically rebased without conflicts. |
This PR is a backport of openjdk/jdk#16148.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/234/head:pull/234
$ git checkout pull/234
Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/234/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 234
View PR using the GUI difftool:
$ git pr show -t 234
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/234.diff
Webrev
Link to Webrev Comment