Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name #234

Closed
wants to merge 3 commits into from

Conversation

psoujany
Copy link
Contributor

@psoujany psoujany commented Feb 5, 2024

This PR is a backport of openjdk/jdk#16148.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8311893 needs maintainer approval

Issue

  • JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/234/head:pull/234
$ git checkout pull/234

Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 234

View PR using the GUI difftool:
$ git pr show -t 234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/234.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2024

👋 Welcome back psoujany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 783ae56634a3bca23516c22b071d224fec18591f 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 5, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

⚠️ @psoujany This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@psoujany
Copy link
Contributor Author

psoujany commented Feb 8, 2024

/approval

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@psoujany usage: /approval [<id>] (request|cancel) [<text>]

@psoujany
Copy link
Contributor Author

psoujany commented Feb 8, 2024

@hns Could you please add jdk21 tag in the OpenJDK issue. Thank you.
https://bugs.openjdk.org/browse/JDK-8311893

@openjdk openjdk bot added the approval label Feb 19, 2024
@GoeLin
Copy link
Member

GoeLin commented Feb 19, 2024

You are missing the fix-request comments. Please read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix.
Removing the tags in the meantime.

@openjdk openjdk bot removed the approval label Feb 19, 2024
@psoujany
Copy link
Contributor Author

psoujany commented Feb 19, 2024

/approval request JDK21 generates docs with violations which got fixed in later release i.e 23. Hence requesting this backport which resolves couple of the violations. Risk would be moderate as this affects javadoc generation. No regressions shown in Tier1 and javadoc tests from jdk21u-dev.

@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@psoujany usage: /approval [<id>] (request|cancel) [<text>]

@psoujany
Copy link
Contributor Author

/approval request JDK21 generates docs with couple of violations which got fixed in later release i.e 23. Hence requesting this backport. No regressions shown in Tier1 and javadoc tests from jdk21u-dev.

@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@psoujany
8311893: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 19, 2024
@psoujany
Copy link
Contributor Author

@GoeLin I've raised fix request. Thank you.

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@psoujany This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • a9792a8: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • d6f4f5e: 8318737: Fallback linker passes bad JNI handle
  • 4d4c47d: 8320890: [AIX] Find a better way to mimic dl handle equality
  • 93be33c: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
  • 70112e3: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"
  • e181516: 8315602: Open source swing security manager test
  • 70fa49e: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • 1c92a05: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java
  • 941ca60: 8009550: PlatformPCSC should load versioned so
  • ... and 23 more: https://git.openjdk.org/jdk21u-dev/compare/38c5df13ab06d012a017e908893cb59288fe1324...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@hns) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 21, 2024
@psoujany
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@psoujany
Your change (at version 1998a65) is now ready to be sponsored by a Committer.

@psoujany
Copy link
Contributor Author

@GoeLin Could you please sponsor this fix. Thank you.

@GoeLin
Copy link
Member

GoeLin commented Feb 22, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

Going to push as commit e69b611.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 290cd11: 8321408: Add Certainly roots R1 and E1
  • 9adc281: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
  • 3b4932b: 8315726: Open source several AWT applet tests
  • 92d533e: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 36569de: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • a9792a8: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • d6f4f5e: 8318737: Fallback linker passes bad JNI handle
  • 4d4c47d: 8320890: [AIX] Find a better way to mimic dl handle equality
  • ... and 29 more: https://git.openjdk.org/jdk21u-dev/compare/38c5df13ab06d012a017e908893cb59288fe1324...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2024
@openjdk openjdk bot closed this Feb 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@GoeLin @psoujany Pushed as commit e69b611.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants