8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...)

[chrisdennis]

This is a backport of d5a207994b9c374e6638e57826326f8f4593b96b from openjdk/jdk which is a bug-fix of JDK-8362123.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8362123 needs maintainer approval

Issue

• JDK-8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...) (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2346/head:pull/2346
$ git checkout pull/2346

Update a local copy of the PR:
$ git checkout pull/2346
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2346

View PR using the GUI difftool:
$ git pr show -t 2346

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2346.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chrisdennis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chrisdennis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 886d96e: 8323803: ConstantOopReadValue::print_on should print 'null' instead of 'nullptr'
• 2f321a5: Merge
• 7f14648: 8369643: [21u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 21.0.9
• ... and 23 more: https://git.openjdk.org/jdk21u-dev/compare/32fb490fcd88886a4b43227754bf6286acba7307...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @chrisdennis This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (e09d980b)

[chrisdennis]

/approval request This fixes a memory leak and/or prompt garbage collection issue introduced in Java 21

[openjdk]

@chrisdennis
8362123: The approval request has been created successfully.

[GoeLin]

Hi @chrisdennis
I am not sure this is a good backport as it adds a public method. Do we need a CSR?
Also, if this was introduced in 21, can you please point out the change that did this and link it as "caused by"?
Thanks.

[chrisdennis]

This isn't adding a new public (API) method it's just adding a missing override of an existing public method in a private static inner class of Executors.

The bug was introduced when the Executors.newSingleThreadExecutor(...) moved from a finalize() based approach for last chance cleanup to a Cleaner based one. The commit that introduced it was therefore 2e78d83 (JDK-8302899). Unfortunately, I don't think I can create a link reflecting this as I lack direct JBS access due to being only a Contributor.

[GoeLin]

Thanks for the update!

[chrisdennis]

/integrate

[openjdk]

@chrisdennis
Your change (at version e09d980) is now ready to be sponsored by a Committer.

[shipilev]

Thanks for doing this!

/sponsor

[openjdk]

Going to push as commit 2a7c7bf.
Since your change was applied there have been 29 commits pushed to the master branch:

• 985c61e: 8367904: Test java/net/InetAddress/ptr/Lookup.java should throw SkippedException
• d4d10c8: 8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler
• 13f88dc: 8355387: [jittester] Disable downcasts by default
• ... and 26 more: https://git.openjdk.org/jdk21u-dev/compare/32fb490fcd88886a4b43227754bf6286acba7307...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @chrisdennis Pushed as commit 2a7c7bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.