Skip to content

8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler#2357

Closed
feilongjiang wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-feilongjiang-72663695-master
Closed

8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler#2357
feilongjiang wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-feilongjiang-72663695-master

Conversation

@feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Oct 19, 2025

Hi all,

This pull request contains a backport of commit 72663695 from the openjdk/jdk repository.

The commit being backported was authored by Feilong Jiang on 14 Oct 2025 and was reviewed by Fei Yang and Ludovic Henry.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369616 needs maintainer approval

Issue

  • JDK-8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2357/head:pull/2357
$ git checkout pull/2357

Update a local copy of the PR:
$ git checkout pull/2357
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2357/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2357

View PR using the GUI difftool:
$ git pr show -t 2357

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2357.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2025

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 19, 2025

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 72663695da9a51c8eefbd496f14a6d1625ad7b42 8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler Oct 19, 2025
@openjdk
Copy link

openjdk bot commented Oct 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 19, 2025
@openjdk
Copy link

openjdk bot commented Oct 19, 2025

⚠️ @feilongjiang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2025

Webrevs

@feilongjiang
Copy link
Member Author

/approval request Clean backport to fix signal handler based profilers on RISC-V

@openjdk
Copy link

openjdk bot commented Oct 19, 2025

@feilongjiang
8369616: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 19, 2025
@feilongjiang
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 23, 2025
@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@feilongjiang
Your change (at version 2396e95) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

Going to push as commit d4d10c8.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 23, 2025
@openjdk openjdk bot closed this Oct 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 23, 2025
@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@RealFYang @feilongjiang Pushed as commit d4d10c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants