8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support#2367
8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support#2367cost0much wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
|
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 40 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Fixes nsk jvmti tests and removes them from ProblemList-Virtual.txt. Applies cleanly from JDK25 and no bugtail. Passes GHA and jtreg tier1-4 and tck testing on main platforms; see PR for more details. Low risk as only test code change. |
|
@cost0much |
|
/integrate |
|
@cost0much |
|
/sponsor |
|
Going to push as commit ff99698.
Your commit was automatically rebased without conflicts. |
|
@phohensee @cost0much Pushed as commit ff99698. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport. Fixes nsk jvmti tests and removes them from
ProblemList-Virtual.txt. GHA passes, and ran on internal Amazon pipelines with change passing jtreg tier1-4 and tck tests on platforms linux x64, aarch64, aarch32; alpine x64, aarch64; mac aarch64; windows x64.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2367/head:pull/2367$ git checkout pull/2367Update a local copy of the PR:
$ git checkout pull/2367$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2367/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2367View PR using the GUI difftool:
$ git pr show -t 2367Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2367.diff
Using Webrev
Link to Webrev Comment