Skip to content

8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu#2382

Closed
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-aec13888-master
Closed

8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu#2382
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-aec13888-master

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 23, 2025

Hi all,

This pull request contains a backport of commit aec13888 from the openjdk/jdk repository.

The commit being backported was authored by Casper Norrbin on 23 Oct 2025 and was reviewed by Severin Gehwolf, Matthias Baesken and SendaoYan.

Thanks!


Progress

  • JDK-8313770 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2382/head:pull/2382
$ git checkout pull/2382

Update a local copy of the PR:
$ git checkout pull/2382
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2382

View PR using the GUI difftool:
$ git pr show -t 2382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2382.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 100 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport aec138886ec2dff765ed810059a1c7b9905c43ca 8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu Oct 23, 2025
@openjdk
Copy link

openjdk bot commented Oct 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 23, 2025
@openjdk
Copy link

openjdk bot commented Oct 23, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug which cause test fails intermittently. Change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@sendaoYan
8313770: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Nov 11, 2025
@GoeLin
Copy link
Member

GoeLin commented Nov 11, 2025

Hi @sendaoYan,
I would prefer if you only request approval for 17 & 21 once it is in 25. I would like to avoid that
changes reach the January update in 21 and 17, but not the corresponding 25 January update.
Making an exception here as it's test-only.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 11, 2025
@sendaoYan
Copy link
Member Author

sendaoYan commented Nov 11, 2025

Hi @sendaoYan, I would prefer if you only request approval for 17 & 21 once it is in 25. I would like to avoid that changes reach the January update in 21 and 17, but not the corresponding 25 January update. Making an exception here as it's test-only.

Got it, I will pay attention next time to add request approval. And I will integrate this to jdk17/21 after jdk25.

@sendaoYan
Copy link
Member Author

jdk25u has been integrated.

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

Going to push as commit 928ac3a.
Since your change was applied there have been 105 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2025
@openjdk openjdk bot closed this Dec 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2025
@openjdk
Copy link

openjdk bot commented Dec 1, 2025

@sendaoYan Pushed as commit 928ac3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants