8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector

[SoniaZaldana]

Hi all,

This pull request contains a backport of commit f804f865 from the openjdk/jdk repository.

The commit being backported was authored by Emanuel Peter on 13 Sep 2023 and was reviewed by Christian Hagedorn and Vladimir Kozlov.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8314612 needs maintainer approval

Issue

• JDK-8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/24.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a1f03a66)

[jerboaa]

Please apply for approval.

[jerboaa]

I'd like to hear what kind of testing specific to the patch has been done before approving.

[SoniaZaldana]

Hi @jerboaa,

I reproduced the issue prior to the patch / ensured the test passed after the patch. I followed your advice and ran the compiler test suite. I created a job to run it across all platforms with GHA (https://github.com/SoniaZaldana/jdk21u-dev/actions/runs/7211451037). Note how the 2 commits in the branch that triggered the job are the backport commit and a commit editing the workflow file to trigger the testsuite. (master...SoniaZaldana:jdk21u-dev:my-backport-8314612)

Happy to do further testing if you have more suggestions! Thanks.

[jerboaa]

Thanks.

/approve yes

[openjdk]

@jerboaa
8314612: The approval request has been approved.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 63aecc5: 8320300: Adjust hs_err output in malloc/mmap error cases
• e8cf56c: 8320798: Console read line with zero out should zero out underlying buffer
• d65289d: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
• 901048b: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
• 0106db0: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics
• 0e0e897: 8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[SoniaZaldana]

/integrate

[openjdk]

@SoniaZaldana
Your change (at version a1f03a6) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit db343c9.
Since your change was applied there have been 6 commits pushed to the master branch:

• 63aecc5: 8320300: Adjust hs_err output in malloc/mmap error cases
• e8cf56c: 8320798: Console read line with zero out should zero out underlying buffer
• d65289d: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
• 901048b: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
• 0106db0: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics
• 0e0e897: 8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @SoniaZaldana Pushed as commit db343c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.