Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector #24

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Dec 13, 2023

Hi all,

This pull request contains a backport of commit f804f865 from the openjdk/jdk repository.

The commit being backported was authored by Emanuel Peter on 13 Sep 2023 and was reviewed by Christian Hagedorn and Vladimir Kozlov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314612 needs maintainer approval

Issue

  • JDK-8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/24.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f804f8652da71b18cc654c08c12d07d6fd43c2a7 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 13, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

Please apply for approval.

@openjdk openjdk bot added the approval label Dec 14, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

I'd like to hear what kind of testing specific to the patch has been done before approving.

@SoniaZaldana
Copy link
Member Author

Hi @jerboaa,

I reproduced the issue prior to the patch / ensured the test passed after the patch. I followed your advice and ran the compiler test suite. I created a job to run it across all platforms with GHA (https://github.com/SoniaZaldana/jdk21u-dev/actions/runs/7211451037). Note how the 2 commits in the branch that triggered the job are the backport commit and a commit editing the workflow file to trigger the testsuite. (master...SoniaZaldana:jdk21u-dev:my-backport-8314612)

Happy to do further testing if you have more suggestions! Thanks.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 15, 2023

Thanks.

/approve yes

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@jerboaa
8314612: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 63aecc5: 8320300: Adjust hs_err output in malloc/mmap error cases
  • e8cf56c: 8320798: Console read line with zero out should zero out underlying buffer
  • d65289d: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
  • 901048b: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 0106db0: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics
  • 0e0e897: 8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 15, 2023
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@SoniaZaldana
Your change (at version a1f03a6) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 15, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

Going to push as commit db343c9.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 63aecc5: 8320300: Adjust hs_err output in malloc/mmap error cases
  • e8cf56c: 8320798: Console read line with zero out should zero out underlying buffer
  • d65289d: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
  • 901048b: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 0106db0: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics
  • 0e0e897: 8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2023
@openjdk openjdk bot closed this Dec 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@jerboaa @SoniaZaldana Pushed as commit db343c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants