8367021: Regression in LocaleDataTest refactoring#2405
8367021: Regression in LocaleDataTest refactoring#2405GoeLin wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
6870c5f to
fbaec13
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/intregrate |
|
@GoeLin Unknown command |
reinrich
left a comment
There was a problem hiding this comment.
Looks good.
Cheers, Richard.
|
/integrate |
|
Thanks for the quick re-review! |
|
Going to push as commit 446b9b5. |
I backport this for parity with 21.0.10-oracle.
Resolved @bug statement.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2405/head:pull/2405$ git checkout pull/2405Update a local copy of the PR:
$ git checkout pull/2405$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2405/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2405View PR using the GUI difftool:
$ git pr show -t 2405Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2405.diff
Using Webrev
Link to Webrev Comment