Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324637: [aix] Implement support for reporting swap space in jdk.management #243

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Feb 7, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324637 needs maintainer approval

Issue

  • JDK-8324637: [aix] Implement support for reporting swap space in jdk.management (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/243/head:pull/243
$ git checkout pull/243

Update a local copy of the PR:
$ git checkout pull/243
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 243

View PR using the GUI difftool:
$ git pr show -t 243

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/243.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 33324a59ccdb220250cb74e15ce13af0e99dcb07 8324637: [aix] Implement support for reporting swap space in jdk.management Feb 7, 2024
@openjdk
Copy link

openjdk bot commented Feb 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 7, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 7, 2024
@GoeLin
Copy link
Member

GoeLin commented Feb 8, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@GoeLin
8324637: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324637: [aix] Implement support for reporting swap space in jdk.management

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 8, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Feb 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

Going to push as commit bed2eaa.
Since your change was applied there have been 3 commits pushed to the master branch:

  • d08f24a: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • cfceb11: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX
  • 98e6d04: 8319777: Zero: Support 8-byte cmpxchg

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2024
@openjdk openjdk bot closed this Feb 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@MBaesken Pushed as commit bed2eaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants