Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 7, 2025

Clean backport from 25, but it needed adaptions to Java 21.

In 21, Instant does not have a method until(). See second commit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8365790 needs maintainer approval

Issue

  • JDK-8365790: Shutdown hook for application image does not work on Windows (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2452/head:pull/2452
$ git checkout pull/2452

Update a local copy of the PR:
$ git checkout pull/2452
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2452

View PR using the GUI difftool:
$ git pr show -t 2452

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2452.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin changed the title Goetz backport 8365790 backport 8b686d9ee4669d31b306d7a3337a0b57e95c9a4c Nov 7, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365790: Shutdown hook for application image does not work on Windows

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • db16554: 8353661: Open source several swing tests batch5
  • 634d3fa: 8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 8b686d9ee4669d31b306d7a3337a0b57e95c9a4c 8365790: Shutdown hook for application image does not work on Windows Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 7, 2025
@GoeLin GoeLin force-pushed the goetz_backport_8365790 branch from 265668e to ba548cf Compare November 13, 2025 17:06
@GoeLin GoeLin force-pushed the goetz_backport_8365790 branch from ba548cf to 206bf9f Compare November 13, 2025 17:12
@GoeLin GoeLin marked this pull request as ready for review November 13, 2025 18:01
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 14, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Nov 14, 2025

Thanks for this and the prereq reviews! Quite a journey...

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 18, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Nov 18, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

Going to push as commit 569d08b.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 1302534: 8366229: runtime/Thread/TooSmallStackSize.java runs with all collectors
  • db16554: 8353661: Open source several swing tests batch5
  • 634d3fa: 8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2025
@openjdk openjdk bot closed this Nov 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2025
@openjdk
Copy link

openjdk bot commented Nov 18, 2025

@GoeLin Pushed as commit 569d08b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8365790 branch November 18, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants