-
Notifications
You must be signed in to change notification settings - Fork 148
8365790: Shutdown hook for application image does not work on Windows #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
265668e to
ba548cf
Compare
ba548cf to
206bf9f
Compare
|
|
|
Thanks for this and the prereq reviews! Quite a journey... |
|
/integrate |
|
Going to push as commit 569d08b.
Your commit was automatically rebased without conflicts. |
Clean backport from 25, but it needed adaptions to Java 21.
In 21, Instant does not have a method until(). See second commit.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2452/head:pull/2452$ git checkout pull/2452Update a local copy of the PR:
$ git checkout pull/2452$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2452/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2452View PR using the GUI difftool:
$ git pr show -t 2452Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2452.diff
Using Webrev
Link to Webrev Comment