8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main#2456
8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main#2456satyenme wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle. Risk: Low. Ran GHA Sanity Checks and adjusted manual test. Patch is clean. Change has been present in tip since March, 2024, change has been accepted by Oracle (and tests were previously closed source). |
|
/integrate |
|
Going to push as commit bf4a0fc.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main. Converts bug6524424 from old applet format to more modern main function approach. Ran GHA Sanity Checks and adjusted test directly. Patch is clean. Backporting for parity with Oracle.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2456/head:pull/2456$ git checkout pull/2456Update a local copy of the PR:
$ git checkout pull/2456$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2456/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2456View PR using the GUI difftool:
$ git pr show -t 2456Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2456.diff
Using Webrev
Link to Webrev Comment