8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers

[eastig]

Hi all,

This pull request contains a backport of commit 4cd31875 from the openjdk/jdk repository.

The commit being backported was authored by Evgeny Astigeevich on 6 Feb 2024 and was reviewed by Andrew Haley and Nick Gasson.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8324874 needs maintainer approval

Issue

• JDK-8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/246/head:pull/246
$ git checkout pull/246

Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 246

View PR using the GUI difftool:
$ git pr show -t 246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/246.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eastigeevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @eastig This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (18ac5c8a)

[eastig]

/approval request Clean backport to fix fp register clobbering. Tier1 tests pass on Graviton 3.

[openjdk]

@eastig
8324874: The approval request has been created successfully.

[GoeLin]

Hi @eastig,
Running only Tier1 seems very basic testing for a change like this that is brand new in head.

[eastig]

Hi @eastig, Running only Tier1 seems very basic testing for a change like this that is brand new in head.

The code itself is not new. It's been in 21 for almost an year. The fix only renames registers to avoid ABI-restricted registers.
Anyway, I ran tier2 and tier3 of fastdebug on Graviton 3. They passed.

[openjdk]

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 4d4c47d: 8320890: [AIX] Find a better way to mimic dl handle equality
• 93be33c: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
• 70112e3: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"
• e181516: 8315602: Open source swing security manager test
• 70fa49e: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
• 1c92a05: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java
• 941ca60: 8009550: PlatformPCSC should load versioned so
• fb19cb3: 8319314: NMT detail report slow or hangs for large number of mappings
• 3da175b: 8323717: Introduce test keyword for tests that need external dependencies
• 24fae7a: 8324514: ClassLoaderData::print_on should print address of class loader
• ... and 10 more: https://git.openjdk.org/jdk21u-dev/compare/bed2eaa5a87564abd50cc095a9c19b72ecdf74ac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[eastig]

/integrate

[openjdk]

@eastig
Your change (at version 18ac5c8) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit a9792a8.
Since your change was applied there have been 21 commits pushed to the master branch:

• d6f4f5e: 8318737: Fallback linker passes bad JNI handle
• 4d4c47d: 8320890: [AIX] Find a better way to mimic dl handle equality
• 93be33c: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
• 70112e3: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"
• e181516: 8315602: Open source swing security manager test
• 70fa49e: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
• 1c92a05: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java
• 941ca60: 8009550: PlatformPCSC should load versioned so
• fb19cb3: 8319314: NMT detail report slow or hangs for large number of mappings
• 3da175b: 8323717: Introduce test keyword for tests that need external dependencies
• ... and 11 more: https://git.openjdk.org/jdk21u-dev/compare/bed2eaa5a87564abd50cc095a9c19b72ecdf74ac...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @eastig Pushed as commit a9792a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.