-
Notifications
You must be signed in to change notification settings - Fork 130
8323667: Library debug files contain non-reproducible full gcc include paths #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8323667: Library debug files contain non-reproducible full gcc include paths #251
Conversation
Successfully built and tested this change locally. |
👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Enables fully reproducible JDK binaries which may differ if differing gcc toolchain build locations were used. This ensure the binaries are identical when no absolute paths allowed. |
@andrew-m-leonard |
/approve yes |
@GoeLin |
@andrew-m-leonard This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@andrew-m-leonard |
/sponsor |
Going to push as commit 5f32918.
Your commit was automatically rebased without conflicts. |
@savoptik @andrew-m-leonard Pushed as commit 5f32918. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
thank you @savoptik |
Native library debug files contain the full gcc system include paths, which then results in the native library being non-reproducible (via the CRC bytes), if built with differing gcc include path location.
This is a backport of the jdk fix to -fdebug-prefix-map these gcc paths when absolute paths are not allowed for a release build.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/251/head:pull/251
$ git checkout pull/251
Update a local copy of the PR:
$ git checkout pull/251
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/251/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 251
View PR using the GUI difftool:
$ git pr show -t 251
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/251.diff
Webrev
Link to Webrev Comment