Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323667: Library debug files contain non-reproducible full gcc include paths #251

Conversation

andrew-m-leonard
Copy link

@andrew-m-leonard andrew-m-leonard commented Feb 9, 2024

Native library debug files contain the full gcc system include paths, which then results in the native library being non-reproducible (via the CRC bytes), if built with differing gcc include path location.
This is a backport of the jdk fix to -fdebug-prefix-map these gcc paths when absolute paths are not allowed for a release build.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323667 needs maintainer approval

Issue

  • JDK-8323667: Library debug files contain non-reproducible full gcc include paths (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/251/head:pull/251
$ git checkout pull/251

Update a local copy of the PR:
$ git checkout pull/251
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 251

View PR using the GUI difftool:
$ git pr show -t 251

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/251.diff

Webrev

Link to Webrev Comment

@andrew-m-leonard
Copy link
Author

Successfully built and tested this change locally.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2024

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 57fad677819ae3142782f811a8fba94b38f5a74c 8323667: Library debug files contain non-reproducible full gcc include paths Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

⚠️ @andrew-m-leonard This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 9, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2024

Webrevs

@andrew-m-leonard
Copy link
Author

/approval request Enables fully reproducible JDK binaries which may differ if differing gcc toolchain build locations were used. This ensure the binaries are identical when no absolute paths allowed.

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@andrew-m-leonard
8323667: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 9, 2024
@GoeLin
Copy link
Member

GoeLin commented Feb 12, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@GoeLin
8323667: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323667: Library debug files contain non-reproducible full gcc include paths

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b30f9aa: 8325150: (tz) Update Timezone Data to 2024a
  • 0604ce7: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
  • bed2eaa: 8324637: [aix] Implement support for reporting swap space in jdk.management

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 12, 2024
@andrew-m-leonard
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@andrew-m-leonard
Your change (at version c7f3eba) is now ready to be sponsored by a Committer.

@savoptik
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

Going to push as commit 5f32918.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 79bd47a: 8318039: GHA: Bump macOS and Xcode versions
  • b30f9aa: 8325150: (tz) Update Timezone Data to 2024a
  • 0604ce7: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
  • bed2eaa: 8324637: [aix] Implement support for reporting swap space in jdk.management

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 12, 2024
@openjdk openjdk bot closed this Feb 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@savoptik @andrew-m-leonard Pushed as commit 5f32918.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andrew-m-leonard
Copy link
Author

thank you @savoptik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants