Skip to content

8372977: Unnecessary gthread-2.0 loading#2515

Closed
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-5ea2b640-master
Closed

8372977: Unnecessary gthread-2.0 loading#2515
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-5ea2b640-master

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 11, 2025

I backport this for parity with 21.0.11-oracle.

Update: The clean backport breaks the build. There are two gtk implementations in
OpenJDK 21: gtk2 and gtk3. This change adresses gtk3, see description in
original JBS issue. Gtk2 was removed in 8329471: "Remove GTK2" in 24.

Gtk2 implements the same functions as gtk3, so we can not remove
the decls in the header. See second commit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372977 needs maintainer approval

Issue

  • JDK-8372977: Unnecessary gthread-2.0 loading (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2515/head:pull/2515
$ git checkout pull/2515

Update a local copy of the PR:
$ git checkout pull/2515
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2515

View PR using the GUI difftool:
$ git pr show -t 2515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2515.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372977: Unnecessary gthread-2.0 loading

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5ea2b6402114d34465b2ad9e476ab8e36ddeea06 8372977: Unnecessary gthread-2.0 loading Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2025
@GoeLin GoeLin marked this pull request as draft December 11, 2025 15:31
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2025

Webrevs

@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 11, 2025
@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Dec 15, 2025
Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@GoeLin GoeLin marked this pull request as ready for review December 15, 2025 15:08
@openjdk openjdk bot added rfr Pull request is ready for review approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 15, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Dec 17, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

Going to push as commit 335ca2e.
Since your change was applied there have been 9 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2025
@openjdk openjdk bot closed this Dec 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@GoeLin Pushed as commit 335ca2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants