-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318039: GHA: Bump macOS and Xcode versions #254
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request backport applies cleanly, affects CI only |
@gdams This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 79bd47a. |
In GHA, the versions of macOS (note: the version used for build/test, not the target macOS version we compile for) and Xcode are starting to show age. It's time to update to more modern versions.
This change bumps the macOS to 13 (from 11) and Xcode to 14.3.1 (from 12.5.1/11.7). This is a prerequisite change for JDK-8317970 / openjdk/jdk#16155, without which the build SIGSEGVs (presumably some since-fixed issue in Xcode 12.5.1).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/254/head:pull/254
$ git checkout pull/254
Update a local copy of the PR:
$ git checkout pull/254
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/254/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 254
View PR using the GUI difftool:
$ git pr show -t 254
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/254.diff
Webrev
Link to Webrev Comment