Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318039: GHA: Bump macOS and Xcode versions #254

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Feb 12, 2024

In GHA, the versions of macOS (note: the version used for build/test, not the target macOS version we compile for) and Xcode are starting to show age. It's time to update to more modern versions.

This change bumps the macOS to 13 (from 11) and Xcode to 14.3.1 (from 12.5.1/11.7). This is a prerequisite change for JDK-8317970 / openjdk/jdk#16155, without which the build SIGSEGVs (presumably some since-fixed issue in Xcode 12.5.1).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318039 needs maintainer approval

Issue

  • JDK-8318039: GHA: Bump macOS and Xcode versions (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/254/head:pull/254
$ git checkout pull/254

Update a local copy of the PR:
$ git checkout pull/254
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/254/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 254

View PR using the GUI difftool:
$ git pr show -t 254

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/254.diff

Webrev

Link to Webrev Comment

@gdams gdams mentioned this pull request Feb 12, 2024
5 tasks
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2024

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 605c9767291ddf1c409c3e805ffb3182899d06c2 8318039: GHA: Bump macOS and Xcode versions Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

⚠️ @gdams This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2024

Webrevs

@gdams
Copy link
Member Author

gdams commented Feb 12, 2024

/approval request backport applies cleanly, affects CI only

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@gdams
8318039: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318039: GHA: Bump macOS and Xcode versions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 12, 2024
@gdams
Copy link
Member Author

gdams commented Feb 12, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

Going to push as commit 79bd47a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 12, 2024
@openjdk openjdk bot closed this Feb 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 12, 2024
@gdams gdams deleted the xcode branch February 12, 2024 10:41
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@gdams Pushed as commit 79bd47a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant