Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323515: Create test alias "all" for all test roots #256

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 13, 2024

Improves JDK testability by allowing to run all tests easily. Test configuration only change, does not affect product code, and thus is low risk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324647 needs maintainer approval
  • JDK-8323515 needs maintainer approval

Issues

  • JDK-8323515: Create test alias "all" for all test roots (Enhancement - P4 - Approved)
  • JDK-8324647: Invalid test group of lib-test after JDK-8323515 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/256/head:pull/256
$ git checkout pull/256

Update a local copy of the PR:
$ git checkout pull/256
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 256

View PR using the GUI difftool:
$ git pr show -t 256

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/256.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8b9bf758801400e4491326cd4c90fc117b9d97e1 8323515: Create test alias "all" for all test roots Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 13, 2024
@shipilev
Copy link
Member Author

/issue add JDK-8324647

@openjdk openjdk bot added the clean label Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@shipilev
Adding additional issue to issue list: 8324647: Invalid test group of lib-test after JDK-8323515.

@openjdk openjdk bot removed the clean label Feb 13, 2024
@shipilev
Copy link
Member Author

Both backports are clean.

/clean

@openjdk openjdk bot added the clean label Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@shipilev This backport pull request is now marked as clean

@shipilev shipilev marked this pull request as ready for review February 13, 2024 12:02
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Improves JDK testability by allowing to run all tests easily. Test configuration only change, does not affect product code, and thus is low risk. Test group definitions sanity is tested with GHA.

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@shipilev
8323515: The approval request has been created successfully.
8324647: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 14, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323515: Create test alias "all" for all test roots
8324647: Invalid test group of lib-test after JDK-8323515

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • b9cf41d: 8325194: GHA: Add macOS M1 testing
  • 4031ff4: 8324753: [AIX] adjust os_posix after JDK-8318696
  • b0e9a61: 8323671: DevKit build gcc libraries contain full paths to source location
  • 5f32918: 8323667: Library debug files contain non-reproducible full gcc include paths
  • 79bd47a: 8318039: GHA: Bump macOS and Xcode versions
  • b30f9aa: 8325150: (tz) Update Timezone Data to 2024a
  • 0604ce7: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
  • bed2eaa: 8324637: [aix] Implement support for reporting swap space in jdk.management
  • d08f24a: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • cfceb11: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 14, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 14, 2024

Going to push as commit 3f35008.
Since your change was applied there have been 10 commits pushed to the master branch:

  • b9cf41d: 8325194: GHA: Add macOS M1 testing
  • 4031ff4: 8324753: [AIX] adjust os_posix after JDK-8318696
  • b0e9a61: 8323671: DevKit build gcc libraries contain full paths to source location
  • 5f32918: 8323667: Library debug files contain non-reproducible full gcc include paths
  • 79bd47a: 8318039: GHA: Bump macOS and Xcode versions
  • b30f9aa: 8325150: (tz) Update Timezone Data to 2024a
  • 0604ce7: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
  • bed2eaa: 8324637: [aix] Implement support for reporting swap space in jdk.management
  • d08f24a: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • cfceb11: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 14, 2024
@openjdk openjdk bot closed this Feb 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2024
@openjdk
Copy link

openjdk bot commented Feb 14, 2024

@shipilev Pushed as commit 3f35008.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8323515-testgroup-all branch April 24, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant