Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324648: Avoid NoSuchMethodError when instantiating NativePRNG #257

Conversation

olivergillespie
Copy link
Contributor

@olivergillespie olivergillespie commented Feb 13, 2024

Hi all,

This pull request contains a backport of commit 69b2674c from the openjdk/jdk repository.

The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324648 needs maintainer approval

Issue

  • JDK-8324648: Avoid NoSuchMethodError when instantiating NativePRNG (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/257/head:pull/257
$ git checkout pull/257

Update a local copy of the PR:
$ git checkout pull/257
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 257

View PR using the GUI difftool:
$ git pr show -t 257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/257.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2024

👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 69b2674c6861fdb7d9f9cb39e07d50515c73e33a 8324648: Avoid NoSuchMethodError when instantiating NativePRNG Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

⚠️ @olivergillespie This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2024

Webrevs

@olivergillespie
Copy link
Contributor Author

/approval request Performance improvement in SecureRandom. which I have seen on the hot path. Clean backport, simple change with low risk in my opinion.

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@olivergillespie
8324648: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@olivergillespie This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324648: Avoid NoSuchMethodError when instantiating NativePRNG

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2d62854: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 27, 2024
@olivergillespie
Copy link
Contributor Author

/integrate

Note - GHA linux-cross-compile riscv64 is failing, which seems to be globally broken (I checked a few other recent PRs and it's failing everywhere).

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@olivergillespie
Your change (at version 2913778) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Mar 5, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

Going to push as commit d6ad625.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2d62854: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 5, 2024
@openjdk openjdk bot closed this Mar 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@shipilev @olivergillespie Pushed as commit d6ad625.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants