-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8324648: Avoid NoSuchMethodError when instantiating NativePRNG #257
8324648: Avoid NoSuchMethodError when instantiating NativePRNG #257
Conversation
👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
Webrevs
|
/approval request Performance improvement in SecureRandom. which I have seen on the hot path. Clean backport, simple change with low risk in my opinion. |
@olivergillespie |
@olivergillespie This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate Note - GHA linux-cross-compile riscv64 is failing, which seems to be globally broken (I checked a few other recent PRs and it's failing everywhere). |
@olivergillespie |
/sponsor |
@shipilev @olivergillespie Pushed as commit d6ad625. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 69b2674c from the openjdk/jdk repository.
The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/257/head:pull/257
$ git checkout pull/257
Update a local copy of the PR:
$ git checkout pull/257
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/257/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 257
View PR using the GUI difftool:
$ git pr show -t 257
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/257.diff
Webrev
Link to Webrev Comment