Skip to content

8373525: C2: assert(_base == Long) failed: Not a Long#2572

Closed
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-a61a1d32-master
Closed

8373525: C2: assert(_base == Long) failed: Not a Long#2572
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-a61a1d32-master

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 25, 2026

I backport this for parity with 21.0.11-oracle

Addon: I had to adapt the test to oldish jtreg framework.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373525 needs maintainer approval

Issue

  • JDK-8373525: C2: assert(_base == Long) failed: Not a Long (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2572/head:pull/2572
$ git checkout pull/2572

Update a local copy of the PR:
$ git checkout pull/2572
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2572/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2572

View PR using the GUI difftool:
$ git pr show -t 2572

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2572.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 25, 2026

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373525: C2: assert(_base == Long) failed: Not a Long

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a61a1d32a2bbf227081b9da6d101071ceb73076a 8373525: C2: assert(_base == Long) failed: Not a Long Jan 25, 2026
@openjdk
Copy link

openjdk bot commented Jan 25, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 25, 2026
@openjdk
Copy link

openjdk bot commented Jan 25, 2026

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2026

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 26, 2026
@GoeLin
Copy link
Member Author

GoeLin commented Jan 26, 2026

GHA failures: test does not work with jtreg we use for 21. Test needs to be adapted

@openjdk openjdk bot removed clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Jan 26, 2026
@GoeLin
Copy link
Member Author

GoeLin commented Jan 27, 2026

GHA failure after fixing the test:
A win test run failed completely. Saw this in another PR today, too. Unrelated.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2026
@GoeLin
Copy link
Member Author

GoeLin commented Jan 27, 2026

/integrate

@openjdk
Copy link

openjdk bot commented Jan 27, 2026

Going to push as commit 984f421.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2026
@openjdk openjdk bot closed this Jan 27, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2026
@openjdk
Copy link

openjdk bot commented Jan 27, 2026

@GoeLin Pushed as commit 984f421.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants