8314578: Non-verifiable code is emitted when two guards declare pattern variables in colon-switch

[shipilev]

Clean backport to resolve javac compilation bug.

Additional testing:

• New test fails without the fix, passes with it
• langtools_all passes

---

Progress

• Change must not contain extraneous whitespace
• JDK-8314578 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8314578: Non-verifiable code is emitted when two guards declare pattern variables in colon-switch (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/26.diff

Webrev

Link to Webrev Comment

[shipilev]

/approval request Clean backport to resolve javac compilation bug. Applies cleanly. Testing passes.

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@shipilev
8314578: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (9218d6cb)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314578: Non-verifiable code is emitted when two guards declare pattern variables in colon-switch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• fb34573: 8321894: Bump update version for OpenJDK: 21.0.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

Going to push as commit 03acee8.
Since your change was applied there have been 31 commits pushed to the master branch:

• af6df77: 8305971: NPE in JavacProcessingEnvironment for missing enum constructor body
• f55a91a: 8319897: Move StackWatermark handling out of LockStack::contains
• b8a0d9f: 8316229: Enhance class initialization logging
• 5d32860: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
• 0c92460: 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition
• 6644066: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
• 80b5f72: 8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test
• ee7748a: 8317300: javac erroneously allows "final" in front of a record pattern
• d50fd26: 8314990: Generational ZGC: Strong OopStorage stats reported as weak roots
• c3b0c03: 8319668: Fixup of jar filename typo in BadFactoryTest.sh
• ... and 21 more: https://git.openjdk.org/jdk21u-dev/compare/ba79073da5baede8d381cd495fb82379b6775f09...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 03acee8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.