Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322846: Running with -Djdk.tracePinnedThreads set can hang #270

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 19, 2024

Fixes the hang with the diagnostic option.

Additional testing:

  • New test fails without the fix, passes with it
  • Linux AArch64 server fastdebug, all

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322846 needs maintainer approval

Issue

  • JDK-8322846: Running with -Djdk.tracePinnedThreads set can hang (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/270/head:pull/270
$ git checkout pull/270

Update a local copy of the PR:
$ git checkout pull/270
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 270

View PR using the GUI difftool:
$ git pr show -t 270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/270.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport faa9c6909dda635eb008b9dada6e06fca47c17d6 8322846: Running with -Djdk.tracePinnedThreads set can hang Feb 19, 2024
@openjdk
Copy link

openjdk bot commented Feb 19, 2024

This backport pull request has now been updated with issue from the original commit.

@shipilev shipilev force-pushed the JDK-8322846-trace-thread-hang branch from 26db291 to adc6000 Compare February 28, 2024 17:36
@shipilev shipilev marked this pull request as ready for review February 28, 2024 17:37
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@shipilev
Copy link
Member Author

GHA failure during RISC-V build is infrastructural: JDK-8326960.

@shipilev
Copy link
Member Author

/approval request Fixes the hang when using a routine diagnostic option. Applies cleanly. New test reliably fails without the fix. All other tests are passing. Risk is medium-low, as it affects the diagnostic path that is not enabled by default.

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@shipilev
8322846: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322846: Running with -Djdk.tracePinnedThreads set can hang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 29, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

Going to push as commit 76ebcc1.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 29, 2024
@openjdk openjdk bot closed this Feb 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@shipilev Pushed as commit 76ebcc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8322846-trace-thread-hang branch April 26, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant