Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId #271

Closed
wants to merge 1 commit into from

Conversation

mmyxym
Copy link

@mmyxym mmyxym commented Feb 20, 2024

Clean backport of enhancement of generational ZGC to fix the GC ID of SoftReferences clearing.

Additional testing:

  • Linux aarch64 server fastdebug, hotspot_gc with -XX:+UseZGC +XX+ZGenerational

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314629 needs maintainer approval

Issue

  • JDK-8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/271/head:pull/271
$ git checkout pull/271

Update a local copy of the PR:
$ git checkout pull/271
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/271/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 271

View PR using the GUI difftool:
$ git pr show -t 271

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/271.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2024

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 88dafe564f163ed738a8cb6adc449b94e606999f 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId Feb 20, 2024
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2024
@mmyxym
Copy link
Author

mmyxym commented Feb 20, 2024

/approval request Clean backport of enhancement of generational ZGC to fix the GC ID of SoftReferences clearing. Risk is very low.

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@mmyxym
8314629: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 20, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 21, 2024
@mmyxym
Copy link
Author

mmyxym commented Feb 21, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@mmyxym
Your change (at version a6cdab6) is now ready to be sponsored by a Committer.

@mmyxym
Copy link
Author

mmyxym commented Feb 21, 2024

Could committers please help sponsor, thanks!

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

Going to push as commit 36569de.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2024
@openjdk openjdk bot closed this Feb 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@shipilev @mmyxym Pushed as commit 36569de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants