Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320303: Allow PassFailJFrame to accept single window creator #274

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Feb 21, 2024

I backport this for parity with 21.0.3-oracle.
no local.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320303 needs maintainer approval

Issue

  • JDK-8320303: Allow PassFailJFrame to accept single window creator (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/274/head:pull/274
$ git checkout pull/274

Update a local copy of the PR:
$ git checkout pull/274
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 274

View PR using the GUI difftool:
$ git pr show -t 274

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/274.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 83ffc1ac94b8893532d8663b9058592f1714d337 8320303: Allow PassFailJFrame to accept single window creator Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 22, 2024
@GoeLin
Copy link
Member

GoeLin commented Feb 22, 2024

Hi @luchenlin
This is not excercised by our nightly testing. Please run some test that use this locally, like

test/jdk/java/awt/Dialog/ModalDialogTest/ModalDialogTest.java
test/jdk/java/awt/Frame/ALTTABIconBeingErased/ALTTABIconBeingErased.java
test/jdk/java/awt/Icon/IconChangingTest/IconChangingTest.java
test/jdk/java/awt/Icon/IconShowingTest/IconShowingTest.java
test/jdk/java/awt/Icon/IconTransparencyTest/IconTransparencyTest.java
test/jdk/java/awt/Icon/SetLargeIconTest/SetLargeIconTest.java
test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java

@openjdk openjdk bot removed the approval label Feb 23, 2024
@luchenlin
Copy link
Author

Hi @luchenlin This is not excercised by our nightly testing. Please run some test that use this locally, like

test/jdk/java/awt/Dialog/ModalDialogTest/ModalDialogTest.java test/jdk/java/awt/Frame/ALTTABIconBeingErased/ALTTABIconBeingErased.java test/jdk/java/awt/Icon/IconChangingTest/IconChangingTest.java test/jdk/java/awt/Icon/IconShowingTest/IconShowingTest.java test/jdk/java/awt/Icon/IconTransparencyTest/IconTransparencyTest.java test/jdk/java/awt/Icon/SetLargeIconTest/SetLargeIconTest.java test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java

hi @GoeLin , it's tested with
test/jdk/javax/swing/JComboBox/JComboBoxActionEvent.java
test/jdk/javax/swing/JTabbedPane/4209065/bug4209065.java
test/jdk/javax/swing/JRadioButton/bug4380543.java

@openjdk openjdk bot added the approval label Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320303: Allow PassFailJFrame to accept single window creator

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 8ddff70: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
  • 2c38047: 8314835: gtest wrappers should be marked as flagless
  • c80bb72: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
  • e69b611: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
  • 290cd11: 8321408: Add Certainly roots R1 and E1
  • 9adc281: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
  • 3b4932b: 8315726: Open source several AWT applet tests
  • 92d533e: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 36569de: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 26, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

Going to push as commit 08f9237.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 8ddff70: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
  • 2c38047: 8314835: gtest wrappers should be marked as flagless
  • c80bb72: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
  • e69b611: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
  • 290cd11: 8321408: Add Certainly roots R1 and E1
  • 9adc281: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
  • 3b4932b: 8315726: Open source several AWT applet tests
  • 92d533e: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 36569de: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2024
@openjdk openjdk bot closed this Feb 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@luchenlin Pushed as commit 08f9237.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants