Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321408: Add Certainly roots R1 and E1 #276

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 21, 2024

Clean backport to match 21.0.3-oracle.

Additional testing:

  • jdk/security/infra sun/security/lib/cacerts tests pass with new certificates

Progress

  • JDK-8321408 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321408: Add Certainly roots R1 and E1 (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/276/head:pull/276
$ git checkout pull/276

Update a local copy of the PR:
$ git checkout pull/276
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 276

View PR using the GUI difftool:
$ git pr show -t 276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/276.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f3073db42aa80b3ced47edea8d2e8add874fb70f 8321408: Add Certainly roots R1 and E1 Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to add two new root certificates and match 21.0.3-oracle.

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@shipilev
8321408: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321408: Add Certainly roots R1 and E1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 3b4932b: 8315726: Open source several AWT applet tests
  • 92d533e: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 36569de: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • a9792a8: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • d6f4f5e: 8318737: Fallback linker passes bad JNI handle
  • 4d4c47d: 8320890: [AIX] Find a better way to mimic dl handle equality

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 22, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

Going to push as commit 290cd11.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 9adc281: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
  • 3b4932b: 8315726: Open source several AWT applet tests
  • 92d533e: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 36569de: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • a9792a8: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • d6f4f5e: 8318737: Fallback linker passes bad JNI handle
  • 4d4c47d: 8320890: [AIX] Find a better way to mimic dl handle equality

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2024
@openjdk openjdk bot closed this Feb 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev Pushed as commit 290cd11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8321408-certainly-roots branch April 24, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant