Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled #280

Closed
wants to merge 1 commit into from

Conversation

mmyxym
Copy link

@mmyxym mmyxym commented Feb 22, 2024

Clean backport of fix of pretouch for parallel gc. The original issue is reproduced with linux/aarch64 and fix is verified.

Additional testing:

  • Linux aarch64 server release/fastdebug, hotspot_gc with -XX:+UseParallelGC -XX:+AlwaysPreTouch

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324817 needs maintainer approval

Issue

  • JDK-8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/280/head:pull/280
$ git checkout pull/280

Update a local copy of the PR:
$ git checkout pull/280
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 280

View PR using the GUI difftool:
$ git pr show -t 280

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/280.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2024

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 80642dd7af3fcc7c042f11798c5cc899e20b9368 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 22, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2024

Webrevs

@mmyxym
Copy link
Author

mmyxym commented Feb 22, 2024

/approval request Clean backport of fix of pretouch for parallel gc. The original issue is reproduced with linux/aarch64 and fix is verified. The risk is quite low since it only fixed the granularity of pretouch size and won't have any other affection.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@mmyxym
8324817: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 64b70be: 8326773: Bump update version for OpenJDK: jdk-21.0.4
  • 36b5ac4: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
  • 4296ddf: 8325496: Make TrimNativeHeapInterval a product switch
  • 1b7c5af: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 55f9bcf: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 69aa4ab: 8325470: [AIX] use fclose after fopen in read_psinfo
  • 08f9237: 8320303: Allow PassFailJFrame to accept single window creator
  • 8ddff70: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
  • 2c38047: 8314835: gtest wrappers should be marked as flagless
  • c80bb72: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/92d533e78210c7a9fb50720ce81ef577d01543f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 27, 2024
@mmyxym
Copy link
Author

mmyxym commented Feb 28, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@mmyxym
Your change (at version 8bbbe3e) is now ready to be sponsored by a Committer.

@mmyxym
Copy link
Author

mmyxym commented Feb 28, 2024

Could committers please help sponsor, thanks!

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

Going to push as commit ef13a82.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 64b70be: 8326773: Bump update version for OpenJDK: jdk-21.0.4
  • 36b5ac4: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
  • 4296ddf: 8325496: Make TrimNativeHeapInterval a product switch
  • 1b7c5af: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 55f9bcf: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 69aa4ab: 8325470: [AIX] use fclose after fopen in read_psinfo
  • 08f9237: 8320303: Allow PassFailJFrame to accept single window creator
  • 8ddff70: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
  • 2c38047: 8314835: gtest wrappers should be marked as flagless
  • c80bb72: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/92d533e78210c7a9fb50720ce81ef577d01543f1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2024
@openjdk openjdk bot closed this Feb 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@DamonFool @mmyxym Pushed as commit ef13a82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants