Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information #289

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 24, 2024

The testcase implement and the commnet is unmatch. Just modify the comment. The risk is low.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8325024 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/289/head:pull/289
$ git checkout pull/289

Update a local copy of the PR:
$ git checkout pull/289
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 289

View PR using the GUI difftool:
$ git pr show -t 289

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/289.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 24, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 432756b6e51c903e2bff8b9c3028a4f2ea8973f4 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information Feb 24, 2024
@openjdk
Copy link

openjdk bot commented Feb 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 24, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 24, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Mar 4, 2024

Hi @sendaoYan, please finish this backport. It's easy enough.
I recommend using https://github.com/pulls aka https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3AsendaoYan+archived%3Afalse+
to track your open PRs. I check this list every day to see the progress of the issues and react.

@sendaoYan
Copy link
Member Author

Hi @sendaoYan, please finish this backport. It's easy enough. I recommend using https://github.com/pulls aka https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3AsendaoYan+archived%3Afalse+ to track your open PRs. I check this list every day to see the progress of the issues and react.

Sorry. I will track mine PRs this two days.

@sendaoYan
Copy link
Member Author

/approval request The testcase implement and the commnet is unmatch. Just modify the comment. The risk is low.

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@sendaoYan
8325024: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 5, 2024
@sendaoYan sendaoYan changed the title 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information 8326113: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information Mar 5, 2024
@openjdk openjdk bot removed the approval label Mar 5, 2024
@sendaoYan sendaoYan changed the title 8326113: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information Mar 5, 2024
@openjdk openjdk bot added the approval label Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

  • ad1d324: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 930344a: Merge
  • 29bf21f: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 4244cb0: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
  • d6ad625: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • 2d62854: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java
  • fdbed07: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • dbcce04: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 500d85a: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • ... and 64 more: https://git.openjdk.org/jdk21u-dev/compare/ffab458d5c08866bd29198b8019637093f089eb5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 6, 2024
@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@sendaoYan
Your change (at version 0823b1c) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Mar 7, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

Going to push as commit e328bf3.
Since your change was applied there have been 79 commits pushed to the master branch:

  • 5c3dfe4: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27
  • e8d2535: 8315609: Open source few more swing text/html tests
  • 555f824: 8315898: Open source swing JMenu tests
  • bfaec80: 8325972: Add -x to bash for building with LOG=debug
  • e071843: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • ad1d324: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 930344a: Merge
  • 29bf21f: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 4244cb0: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
  • d6ad625: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • ... and 69 more: https://git.openjdk.org/jdk21u-dev/compare/ffab458d5c08866bd29198b8019637093f089eb5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2024
@openjdk openjdk bot closed this Mar 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2024
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@shipilev @sendaoYan Pushed as commit e328bf3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

@shipilev Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants