8310308: IR Framework: check for type and size of vector nodes

[GoeLin]

I backport this to improve testing of C2 in 22u. It will simplify backporting tests of fixes to C2, as, e.g. " 8313720: C2 SuperWord: wrong result with -XX:+UseVectorCmov -XX:+UseCMoveUnconditionally"

I had to trivially resolve three files:

test/hotspot/jtreg/compiler/loopopts/superword/TestDependencyOffsets.java
Resolved the bugid in comment.

patching file test/hotspot/jtreg/compiler/vectorization/runner/BasicDoubleOpTest.java
patching file test/hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java
These had to be resolved because "8308340: C2: Idealize Fma nodes" is not in 21. Trivial.
That change is huge thus not a candidate for backport.

Further I include "8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake". This is a follow-up fix of the tests.

All tests passed locally.

It's a test-only change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8314513 needs maintainer approval
• JDK-8310308 needs maintainer approval

Issues

• JDK-8310308: IR Framework: check for type and size of vector nodes (Enhancement - P4 - Approved)
• JDK-8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/29.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[GoeLin]

/issue 8314513

[openjdk]

@GoeLin
Adding additional issue to issue list: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake.

[mlbridge]

Webrevs

• 02: Full - Incremental (b9ca277d)
• 01: Full - Incremental (326ac31e)
• 00: Full (c3448ad7)

[GoeLin]

Pre-submit: compiler/c2/irTests/TestVectorizationMismatchedAccess failed.

[GoeLin]

TestVectorizationMismatchedAccess.java was failing.
This is because in head, subtest testByteByte2 was enabled by 8310308. But in 21, it is disabled.
If I enable it in 21 without this change, it fails with the same message as with the change. So I disabled it again.

As I understand, 21 does not generate vector nodes for the test method, and in 22 there was a functional improvement.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310308: IR Framework: check for type and size of vector nodes
8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

• 7927315: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
• aaee2d7: 8322040: Missing array bounds check in ClassReader.parameter
• 636607b: 8313816: Accessing jmethodID might lead to spurious crashes
• e4056b9: 8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)
• 12915c3: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from
• e0de68e: 8209595: MonitorVmStartTerminate.java timed out
• 2f65dda: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
• 840724b: 8317188: G1: Make TestG1ConcRefinementThreads use createTestJvm
• a6c2398: 8317218: G1: Make TestG1HeapRegionSize use createTestJvm
• a565d49: 8317316: G1: Make TestG1PercentageOptions use createTestJvm
• ... and 51 more: https://git.openjdk.org/jdk21u-dev/compare/fb34573636079ff1ddbf193f86e72b4fb55c1e7d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 6b938b8.
Since your change was applied there have been 62 commits pushed to the master branch:

• 506c4de: 8313854: Some tests in serviceability area fail on localized Windows platform
• 7927315: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
• aaee2d7: 8322040: Missing array bounds check in ClassReader.parameter
• 636607b: 8313816: Accessing jmethodID might lead to spurious crashes
• e4056b9: 8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)
• 12915c3: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from
• e0de68e: 8209595: MonitorVmStartTerminate.java timed out
• 2f65dda: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
• 840724b: 8317188: G1: Make TestG1ConcRefinementThreads use createTestJvm
• a6c2398: 8317218: G1: Make TestG1HeapRegionSize use createTestJvm
• ... and 52 more: https://git.openjdk.org/jdk21u-dev/compare/fb34573636079ff1ddbf193f86e72b4fb55c1e7d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 6b938b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.