Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 #298

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Feb 28, 2024

I backport this for parity with 21.0.3-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318580 needs maintainer approval

Issue

  • JDK-8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/298/head:pull/298
$ git checkout pull/298

Update a local copy of the PR:
$ git checkout pull/298
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 298

View PR using the GUI difftool:
$ git pr show -t 298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/298.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e4803e0cbf00da89b98c8703769edc403bb5055b 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • e667521: 8324123: aarch64: fix prfm literal encoding in assembler
  • 76ebcc1: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
  • 3eb5517: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • cea29fe: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 677556d: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • 8ac4313: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 1, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 4, 2024

Going to push as commit 500d85a.
Since your change was applied there have been 10 commits pushed to the master branch:

  • ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 94634c0: 8313394: Array Elements in OldObjectSample event has the incorrect description
  • 4243aed: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs
  • e667521: 8324123: aarch64: fix prfm literal encoding in assembler
  • 76ebcc1: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
  • 3eb5517: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • cea29fe: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 677556d: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • 8ac4313: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2024
@openjdk openjdk bot closed this Mar 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

@luchenlin Pushed as commit 500d85a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant