Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324123: aarch64: fix prfm literal encoding in assembler #299

Closed
wants to merge 1 commit into from

Conversation

mmyxym
Copy link

@mmyxym mmyxym commented Feb 28, 2024

Clean backport of fix of aarch64 PRFM (literal) encoding.

Additional testing:

  • Linux aarch64 server fastdebug, tier1

Progress

  • JDK-8324123 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324123: aarch64: fix prfm literal encoding in assembler (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/299/head:pull/299
$ git checkout pull/299

Update a local copy of the PR:
$ git checkout pull/299
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/299/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 299

View PR using the GUI difftool:
$ git pr show -t 299

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/299.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bde87895c8b1b9df198e3883d24cd9ea840efc98 8324123: aarch64: fix prfm literal encoding in assembler Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@mmyxym
Copy link
Author

mmyxym commented Feb 28, 2024

/approval request Clean backport of fix of aarch64 PRFM (literal) encoding. Risk is very low since the encoding is not used yet in code base.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@mmyxym
8324123: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 28, 2024
@GoeLin
Copy link
Member

GoeLin commented Feb 29, 2024

@mmyxym GHA Tests are failing.

@mmyxym
Copy link
Author

mmyxym commented Feb 29, 2024

@mmyxym GHA Tests are failing.

@GoeLin , it's a riscv64 build failure not related to compilation(the commit only changes aarch64):
"Extracting libpam0t64...
E: Tried to extract package, but file already exists. Exit...
Error: Process completed with exit code 1."
Looks like a GHA infra issue.

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324123: aarch64: fix prfm literal encoding in assembler

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 76ebcc1: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
  • 3eb5517: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 29, 2024
@mmyxym
Copy link
Author

mmyxym commented Feb 29, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@mmyxym
Your change (at version ddb61da) is now ready to be sponsored by a Committer.

@mmyxym
Copy link
Author

mmyxym commented Feb 29, 2024

Could committers please help sponsor, thanks!

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

Going to push as commit e667521.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 76ebcc1: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
  • 3eb5517: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 29, 2024
@openjdk openjdk bot closed this Feb 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@phohensee @mmyxym Pushed as commit e667521.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants