Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315677: Open source few swing JFileChooser and other tests #300

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link

@amosshi amosshi commented Feb 28, 2024

Backport of JDK-8315677

Testing

  • Local: Test passed
    • bug4624353.java - Test results: passed: 1
    • bug4673161.java - Test results: no tests selected
    • bug4782168.java - Test results: passed: 1
    • bug4822331.java - Test results: passed: 1
    • bug4191835.java - Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-03-01,02,05

Progress

  • JDK-8315677 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315677: Open source few swing JFileChooser and other tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/300/head:pull/300
$ git checkout pull/300

Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 300

View PR using the GUI difftool:
$ git pr show -t 300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/300.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fe5ef5f20dcf647b4ca30963b42fa01449f0d9c0 8315677: Open source few swing JFileChooser and other tests Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@amosshi
8315677: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 7, 2024
@amosshi
Copy link
Author

amosshi commented Mar 7, 2024

/approval request “Backporting for parity with jdk 21.0.04-oracle. Clean backport. Test case only, no risk. SAP nightlies passed on 2024-03-01,02,05”

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@amosshi
8315677: The approval request has been updated successfully.

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315677: Open source few swing JFileChooser and other tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • c26cad3: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test
  • 315d051: 8314828: Mark 3 jcmd command-line options test as vm.flagless
  • ab6e027: 8320712: Rewrite BadFactoryTest in pure Java
  • 40f0254: 8323276: StressDirListings.java fails on AIX
  • d4823c2: 8322477: order of subclasses in the permits clause can differ between compilations
  • 0b01feb: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown
  • e7994c1: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java
  • 5838aed: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags
  • 45e20c5: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
  • 2267292: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out
  • ... and 29 more: https://git.openjdk.org/jdk21u-dev/compare/36b5ac46ed4cb450a17fc993d2b734c0a8e32bc0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 7, 2024
@amosshi
Copy link
Author

amosshi commented Mar 7, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@amosshi
Your change (at version 526bbc6) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

Going to push as commit 9a8d91a.
Since your change was applied there have been 40 commits pushed to the master branch:

  • c4c4b22: 8325326: [PPC64] Don't relocate in case of allocation failure
  • c26cad3: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test
  • 315d051: 8314828: Mark 3 jcmd command-line options test as vm.flagless
  • ab6e027: 8320712: Rewrite BadFactoryTest in pure Java
  • 40f0254: 8323276: StressDirListings.java fails on AIX
  • d4823c2: 8322477: order of subclasses in the permits clause can differ between compilations
  • 0b01feb: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown
  • e7994c1: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java
  • 5838aed: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags
  • 45e20c5: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
  • ... and 30 more: https://git.openjdk.org/jdk21u-dev/compare/36b5ac46ed4cb450a17fc993d2b734c0a8e32bc0...master

Your commit was automatically rebased without conflicts.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2024
@openjdk openjdk bot closed this Mar 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@TheRealMDoerr @amosshi Pushed as commit 9a8d91a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@TheRealMDoerr The command sponsor can only be used in open pull requests.

@amosshi amosshi deleted the backport-8315677 branch March 13, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants