8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi

[lutkerd]

Backporting to 21 which also has the same issue.

Ran tier1, 2, 3, 4 on linux aarch64 with -XX:+UseShenandoahGC as well as jcstress quick.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325372 needs maintainer approval

Issue

• JDK-8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi (Bug - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/306/head:pull/306
$ git checkout pull/306

Update a local copy of the PR:
$ git checkout pull/306
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 306

View PR using the GUI difftool:
$ git pr show -t 306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/306.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @lutkerd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 02: Full (80c09668)
• 01: Full - Incremental (b4c06430)
• 00: Full (b14b74d6)

[lutkerd]

/approval request Backport to resolve a handful of customer reports. Ran Tier 1,2,3 and 4 as well as jcstress -m quick with -XX:+UseShenandoahGC and did not hit any issues.

[openjdk]

@lutkerd
8325372: The approval request has been created successfully.

[openjdk]

@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[shipilev]

While the patch is still relatively new in mainline, I think this one is good to have earlier in 21u-dev. This is going to be additionally tested by our 21u pipelines, in addition to mainline testing.

There is a GHA failure in x86_32 StringRepeat test, but it does not look relevant.

[lutkerd]

/approval request Backport to resolve a handful of customer reports. Ran Tier 1,2,3 and 4 as well as jcstress -m quick with -XX:+UseShenandoahGC and did not hit any issues. GHA failures is not related to this change and didn't fail on initial run, rerunning to be safe.

[openjdk]

@lutkerd
8325372: The approval request has been updated successfully.

[openjdk]

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• e3b6098: 8322503: Shenandoah: Clarify gc state usage
• 93fd1a1: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
• ad5a087: 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint
• 608c98d: 8326496: [test] checkHsErrFileContent support printing hserr in error case
• d42da09: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case
• 2a6688f: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
• da02da7: 8325432: enhance assert message "relocation addr must be in this section"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lutkerd]

/integrate

[openjdk]

@lutkerd
Your change (at version 80c0966) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit cc65d0d.
Since your change was applied there have been 16 commits pushed to the master branch:

• 6d8d049: 8324632: Update Zlib Data Compression Library to Version 1.3.1
• 5431b82: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
• 5762df6: 8321489: Update LCMS to 2.16
• a69c437: 8316559: Refactor some util/Calendar tests to JUnit
• 390e647: 8313612: Use JUnit in lib-test/jdk tests
• 539b04e: 8314832: Few runtime/os tests ignore vm flags
• 0d3a4e2: 8310818: Refactor more Locale tests to use JUnit
• 166aad0: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests
• 58b3403: 8310234: Refactor Locale tests to use JUnit
• e3b6098: 8322503: Shenandoah: Clarify gc state usage
• ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/c80be84cdda88e83c32eae6e18f7dacc536e5383...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @lutkerd Pushed as commit cc65d0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.