Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space #312

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 1, 2024

Clean backport of JDK-8326101 from JDK 22u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326101 needs maintainer approval

Issue

  • JDK-8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/312/head:pull/312
$ git checkout pull/312

Update a local copy of the PR:
$ git checkout pull/312
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 312

View PR using the GUI difftool:
$ git pr show -t 312

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/312.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

⚠️ @TheRealMDoerr could not find any commit with hash e3ae81eeeee8e2b0063a576a90624dd927b512f0. Please update the title with the hash for an existing commit.

@openjdk openjdk bot changed the title Backport e3ae81eeeee8e2b0063a576a90624dd927b512f0 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request JDK 21 is affected by this bug. The fix is small, only touches two PPC64 files and the version from 22u applies cleanly. The fix has been tested in head for some time and retested in 22u and 21u-dev. No regression found.

@openjdk
Copy link

openjdk bot commented Mar 2, 2024

@TheRealMDoerr
8326101: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 2, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 624e603: 8315834: Open source several Swing JSpinner related tests
  • 066af44: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • 8e439ba: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • 9a8d91a: 8315677: Open source few swing JFileChooser and other tests
  • c4c4b22: 8325326: [PPC64] Don't relocate in case of allocation failure
  • c26cad3: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test
  • 315d051: 8314828: Mark 3 jcmd command-line options test as vm.flagless
  • ab6e027: 8320712: Rewrite BadFactoryTest in pure Java
  • 40f0254: 8323276: StressDirListings.java fails on AIX
  • d4823c2: 8322477: order of subclasses in the permits clause can differ between compilations
  • ... and 22 more: https://git.openjdk.org/jdk21u-dev/compare/94634c08e6eaecbdb61223d390c1fc4f8ebab848...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 11, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit 44fdfc7.
Since your change was applied there have been 44 commits pushed to the master branch:

  • c8e9f1d: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • 7f5afa1: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 7505194: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • 779204c: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • d4e336d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • e2858b5: 8326685: Linux builds not reproducible if two builds configured in different build folders
  • 8f08066: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • a75d19d: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
  • c0b5fdf: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 50f447c: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
  • ... and 34 more: https://git.openjdk.org/jdk21u-dev/compare/94634c08e6eaecbdb61223d390c1fc4f8ebab848...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@TheRealMDoerr Pushed as commit 44fdfc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant