8314828: Mark 3 jcmd command-line options test as vm.flagless#322
8314828: Mark 3 jcmd command-line options test as vm.flagless#322GoeLin wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
/clean |
|
@GoeLin This backport pull request is now marked as clean |
|
|
|
GHA failure: Risc-V compile issue, unrelated. |
|
You should add https://bugs.openjdk.org/browse/JDK-8316228 to this PR then, no? |
|
/issue 8316228 |
|
Yes, you are right, thanks for catching this! |
|
@GoeLin |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 315d051.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 21.0.4-oracle.
As 8312828 breaks the tests, I include follow-up 8316228.
Both are clean backports. Will mark as clean.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/322/head:pull/322$ git checkout pull/322Update a local copy of the PR:
$ git checkout pull/322$ git pull https://git.openjdk.org/jdk21u-dev.git pull/322/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 322View PR using the GUI difftool:
$ git pr show -t 322Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/322.diff
Webrev
Link to Webrev Comment