-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294699: Launcher causes lingering busy cursor #327
Conversation
👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
Webrevs
|
/approval request Parity with Oracle 21.0.4 |
Hi @lutkerd, your fix-request comment is meaningless, and you have failing tests. Please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix. Removing the tag. |
@lutkerd This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 38 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
The failing tests are for linux-x86 but the backport only touches a single .cpp in the Windows components. I think the test failure is a false positive? |
@GoeLin Can we get this merged please? |
@lutkerd I concur on the issue of more meaningful "Fix Request" comments. Those comments are supposed to reason about why it's needed as a backport, what issue it solves, assess the risk, what testing has been done etc. Simply |
Sorry, I've been out of the office a bit. We have a customer request for this, corretto/corretto-21#51. |
/integrate |
/sponsor |
Going to push as commit 8ed46c2.
Your commit was automatically rebased without conflicts. |
Backport for parity with Oracle 21.0.4
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/327/head:pull/327
$ git checkout pull/327
Update a local copy of the PR:
$ git checkout pull/327
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/327/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 327
View PR using the GUI difftool:
$ git pr show -t 327
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/327.diff
Webrev
Link to Webrev Comment