Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294699: Launcher causes lingering busy cursor #327

Closed

Conversation

lutkerd
Copy link

@lutkerd lutkerd commented Mar 4, 2024

Backport for parity with Oracle 21.0.4


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8294699 needs maintainer approval

Issue

  • JDK-8294699: Launcher causes lingering busy cursor (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/327/head:pull/327
$ git checkout pull/327

Update a local copy of the PR:
$ git checkout pull/327
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 327

View PR using the GUI difftool:
$ git pr show -t 327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/327.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2024

👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d3df3eb5d7f5537ade917db7a36caba028f94111 8294699: Launcher causes lingering busy cursor Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 4, 2024

⚠️ @lutkerd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2024

Webrevs

@lutkerd
Copy link
Author

lutkerd commented Mar 4, 2024

/approval request Parity with Oracle 21.0.4

@openjdk
Copy link

openjdk bot commented Mar 4, 2024

@lutkerd
8294699: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 4, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 6, 2024

Hi @lutkerd, your fix-request comment is meaningless, and you have failing tests. Please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix. Removing the tag.

@openjdk openjdk bot removed the approval label Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294699: Launcher causes lingering busy cursor

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 78e35ea: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185
  • 620250b: 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false"
  • d2c6be9: 8317350: Move code cache purging out of CodeCache::UnloadingScope
  • c094d7e: 8317677: Specialize Vtablestubs::entry_for() for VtableBlob
  • 0839687: 8317235: Remove Access API use in nmethod class
  • 32ab4a2: 8316669: ImmutableOopMapSet destructor not called
  • 7c5ff9a: 8316670: Remove effectively unused nmethodBucket::_count
  • 92b237c: 8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java
  • 618a7ba: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic
  • 8d3151f: 8316002: Remove unnecessary seen_dead_loader in ClassLoaderDataGraph::do_unloading
  • ... and 28 more: https://git.openjdk.org/jdk21u-dev/compare/bb8b64635c0dd932cf14f5c04052501b04262040...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@lwahonen
Copy link

lwahonen commented Mar 18, 2024

The failing tests are for linux-x86 but the backport only touches a single .cpp in the Windows components. I think the test failure is a false positive?

@lwahonen
Copy link

lwahonen commented Apr 3, 2024

@GoeLin Can we get this merged please?

@jerboaa
Copy link
Contributor

jerboaa commented Apr 3, 2024

Parity with Oracle 21.0.4

@lutkerd I concur on the issue of more meaningful "Fix Request" comments. Those comments are supposed to reason about why it's needed as a backport, what issue it solves, assess the risk, what testing has been done etc. Simply Parity with Oracle 21.0.4 isn't quite helpful since when looking at the bug, one can see that as well. Please keep that in mind next time.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 3, 2024
@lutkerd
Copy link
Author

lutkerd commented Apr 3, 2024

Sorry, I've been out of the office a bit. We have a customer request for this, corretto/corretto-21#51.

@lutkerd
Copy link
Author

lutkerd commented Apr 3, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@lutkerd
Your change (at version 44a0885) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Apr 8, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

Going to push as commit 8ed46c2.
Since your change was applied there have been 49 commits pushed to the master branch:

  • e1f8f83: 8316460: 4 javax/management tests ignore VM flags
  • 85ca789: 8318962: Update ProcessTools javadoc with suggestions in 8315097
  • 40b1c4b: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12
  • ccaa6d7: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code
  • b80fb5e: 8327468: Do not restart close if errno is EINTR [macOS/linux]
  • bdf5747: 8328709: AIX os::get_summary_cpu_info support Power 10
  • c05f3bf: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
  • 1563c54: 8319153: Fix: Class is a raw type in ProcessTools
  • 702d337: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper
  • 74dcc30: 8288936: Wrong lock ordering writing G1HeapRegionTypeChange JFR event
  • ... and 39 more: https://git.openjdk.org/jdk21u-dev/compare/bb8b64635c0dd932cf14f5c04052501b04262040...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2024
@openjdk openjdk bot closed this Apr 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 8, 2024
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@shipilev @lutkerd Pushed as commit 8ed46c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
5 participants