Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters #332

Closed

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Mar 5, 2024

Hi all,

This pull request contains a backport of commit 82796bdebbf56b98ec97a6d572ed68c2842f60c6 from the openjdk/jdk repository.

Note, patch is not clean.

The only difference between the original commit and this backport is the variable name utf16 (original commit) vs buf (jdk21u state). I coalesced those differences by keeping the buf variable name for jdk21u.

Testing: Was able to verify behaviour with reproducer and added test case passes.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320570 needs maintainer approval

Issue

  • JDK-8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/332/head:pull/332
$ git checkout pull/332

Update a local copy of the PR:
$ git checkout pull/332
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 332

View PR using the GUI difftool:
$ git pr show -t 332

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/332.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 82796bdebbf56b98ec97a6d572ed68c2842f60c6 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 5, 2024
@SoniaZaldana
Copy link
Member Author

GHA failure: Unrelated Risk-V build issue.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review March 6, 2024 19:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • d4e336d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • e2858b5: 8326685: Linux builds not reproducible if two builds configured in different build folders
  • 8f08066: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • a75d19d: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
  • c0b5fdf: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 50f447c: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
  • 3086ed8: 8324834: Use _LARGE_FILES on AIX
  • 83cc4cb: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • 624e603: 8315834: Open source several Swing JSpinner related tests
  • 066af44: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • ... and 23 more: https://git.openjdk.org/jdk21u-dev/compare/4244cb0d9927bd2b6c565b10e6bd40be0c3c7843...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 11, 2024
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@SoniaZaldana
Your change (at version c259f80) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

Going to push as commit 779204c.
Since your change was applied there have been 33 commits pushed to the master branch:

  • d4e336d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • e2858b5: 8326685: Linux builds not reproducible if two builds configured in different build folders
  • 8f08066: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • a75d19d: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
  • c0b5fdf: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 50f447c: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
  • 3086ed8: 8324834: Use _LARGE_FILES on AIX
  • 83cc4cb: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • 624e603: 8315834: Open source several Swing JSpinner related tests
  • 066af44: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • ... and 23 more: https://git.openjdk.org/jdk21u-dev/compare/4244cb0d9927bd2b6c565b10e6bd40be0c3c7843...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2024
@openjdk openjdk bot closed this Mar 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@phohensee @SoniaZaldana Pushed as commit 779204c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants