Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320005: Allow loading of shared objects with .a extension on AIX #335

Conversation

suchismith1993
Copy link

@suchismith1993 suchismith1993 commented Mar 6, 2024

Hi all,

This pull request contains a backport of commit e85355ad from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320005 needs maintainer approval

Issue

  • JDK-8320005: Allow loading of shared objects with .a extension on AIX (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/335/head:pull/335
$ git checkout pull/335

Update a local copy of the PR:
$ git checkout pull/335
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/335/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 335

View PR using the GUI difftool:
$ git pr show -t 335

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/335.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2024

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab 8320005: Allow loading of shared objects with .a extension on AIX Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2024

Webrevs

@suchismith1993
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@suchismith1993 usage: /approval [<id>] (request|cancel) [<text>]

@suchismith1993
Copy link
Author

/approval e85355ada4ac1061c49ee9f1247d37a437c7b5ab request

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@suchismith1993 usage: /approval [<id>] (request|cancel) [<text>]

@suchismith1993
Copy link
Author

/approval request This back port is required to handle dynamic libraries of AIX.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@suchismith1993
8320005: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@suchismith1993 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320005: Allow loading of shared objects with .a extension on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 624e603: 8315834: Open source several Swing JSpinner related tests
  • 066af44: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • 8e439ba: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • 9a8d91a: 8315677: Open source few swing JFileChooser and other tests
  • c4c4b22: 8325326: [PPC64] Don't relocate in case of allocation failure
  • c26cad3: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test
  • 315d051: 8314828: Mark 3 jcmd command-line options test as vm.flagless
  • ab6e027: 8320712: Rewrite BadFactoryTest in pure Java
  • 40f0254: 8323276: StressDirListings.java fails on AIX
  • d4823c2: 8322477: order of subclasses in the permits clause can differ between compilations
  • ... and 13 more: https://git.openjdk.org/jdk21u-dev/compare/930344ad6fb9762fde0636d9042e3350ee90b9cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 11, 2024
@suchismith1993
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@suchismith1993
Your change (at version b12b8fd) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit c80be84.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 44fdfc7: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • c8e9f1d: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • 7f5afa1: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 7505194: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • 779204c: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • d4e336d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • e2858b5: 8326685: Linux builds not reproducible if two builds configured in different build folders
  • 8f08066: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • a75d19d: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
  • c0b5fdf: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • ... and 26 more: https://git.openjdk.org/jdk21u-dev/compare/930344ad6fb9762fde0636d9042e3350ee90b9cf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@TheRealMDoerr @suchismith1993 Pushed as commit c80be84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants