-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java #339
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Fixes the test when running with C1. Does not apply cleanly, because the relevant problemlist change is not applicable to jdk21u. Risk is low, test-only fix. |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit a75d19d.
Your commit was automatically rebased without conflicts. |
Fixes the test when running with C1. Does not apply cleanly, because the relevant problemlist change is not applicable to jdk21u. We backported JDK-8314838 to 21.0.3, which exposes us to this bug.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/339/head:pull/339
$ git checkout pull/339
Update a local copy of the PR:
$ git checkout pull/339
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/339/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 339
View PR using the GUI difftool:
$ git pr show -t 339
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/339.diff
Webrev
Link to Webrev Comment