Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7001133: OutOfMemoryError by CustomMediaSizeName implementation #349

Conversation

AlexanderScherbatiy
Copy link

@AlexanderScherbatiy AlexanderScherbatiy commented Mar 12, 2024

The fix has been tested on Ubuntu and MacOS.
The test test/jdk/javax/print/CustomMediaSizeNameOOMETest.java passes with the fix and fails without the fix.


Progress

  • JDK-7001133 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7001133: OutOfMemoryError by CustomMediaSizeName implementation (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/349/head:pull/349
$ git checkout pull/349

Update a local copy of the PR:
$ git checkout pull/349
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/349/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 349

View PR using the GUI difftool:
$ git pr show -t 349

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/349.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2024

👋 Welcome back alexsch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 10335f60f923aa4f315e64acb2bfd7bb06d47a1b 7001133: OutOfMemoryError by CustomMediaSizeName implementation Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

⚠️ @AlexanderScherbatiy This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 12, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2024

Webrevs

@openjdk openjdk bot added the approval label Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@AlexanderScherbatiy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7001133: OutOfMemoryError by CustomMediaSizeName implementation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 7505194: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • 779204c: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 12, 2024
@AlexanderScherbatiy
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

Going to push as commit 93a4707.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 6b0cfd4: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
  • eaa8ed9: 8324646: Avoid Class.forName in SecureRandom constructor
  • c8ddf40: 8326529: JFR: Test for CompilerCompile events fails due to time out
  • eb4f76e: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • 196a851: 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out
  • 700fd39: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable
  • 6632caa: 8288989: Make tests not depend on the source code
  • 81f621d: 8316696: Remove the testing base classes: IntlTest and CollatorTest
  • dc6afd0: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList
  • b3e8176: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory
  • ... and 27 more: https://git.openjdk.org/jdk21u-dev/compare/d4e336d4b70de9a74c62ccde5d5eb447a3bd5d9a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 19, 2024
@openjdk openjdk bot closed this Mar 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@AlexanderScherbatiy Pushed as commit 93a4707.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant