8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows

[yukikimmura]

I would like to backport JDK-8318410 to 21u-dev because the test dose not work as intended.
The fix applies cleanly to 21u-dev.
I tested BootClassPathTest on Windows(English,Japanese) and Linux(locales used in the test with LANG/LC_ALL/LC_CTYPE).

Could someone please review it?

Thanks,
Kimura Yukihiro

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8318410 needs maintainer approval

Issue

• JDK-8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/36.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @yukikimmura This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (c4df6db6)

[yukikimmura]

/approval request I would like to backport this issue to 21u-dev,
because the test dose not work as intended on some Windows environment,
and it always fails in regression testing, resulting in extra costs for checking the test results,
The fix applies cleanly to 21,
There is no risk because the fix is the same as JDK22, and I verified the fix enough,
Testing:I tested BootClassPathTest on Windows(English,Japanese) and Linux(locales used in the test with LANG/LC_ALL/LC_CTYPE).

[openjdk]

@yukikimmura
8318410: The approval request has been updated successfully.

[openjdk]

@yukikimmura This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• fccb0a1: 8321131: Console read line with zero out should zero out underlying buffer in JLine
• db343c9: 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector
• 63aecc5: 8320300: Adjust hs_err output in malloc/mmap error cases

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[yukikimmura]

/integrate

[openjdk]

@yukikimmura
Your change (at version c4df6db) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 947dfc4.
Since your change was applied there have been 4 commits pushed to the master branch:

• dcf6eea: 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX
• fccb0a1: 8321131: Console read line with zero out should zero out underlying buffer in JLine
• db343c9: 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector
• 63aecc5: 8320300: Adjust hs_err output in malloc/mmap error cases

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @yukikimmura Pushed as commit 947dfc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.