Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325730: StringBuilder.toString allocation for the empty String #364

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 13, 2024

Clean backport to resolve the regression introduced in JDK 19.

Additional testing:

  • Linux x86_64 server fastdebug, all

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325730 needs maintainer approval

Issue

  • JDK-8325730: StringBuilder.toString allocation for the empty String (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/364/head:pull/364
$ git checkout pull/364

Update a local copy of the PR:
$ git checkout pull/364
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 364

View PR using the GUI difftool:
$ git pr show -t 364

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/364.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d2590c69b4efe5aa2b48b08070e0dbafb04ef202 8325730: StringBuilder.toString allocation for the empty String Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@shipilev shipilev marked this pull request as ready for review March 14, 2024 09:26
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant