Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322503: Shenandoah: Clarify gc state usage #365

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Mar 14, 2024

Resolved trivial conflicts


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322503 needs maintainer approval

Issue

  • JDK-8322503: Shenandoah: Clarify gc state usage (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/365/head:pull/365
$ git checkout pull/365

Update a local copy of the PR:
$ git checkout pull/365
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 365

View PR using the GUI difftool:
$ git pr show -t 365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/365.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322503: Shenandoah: Clarify gc state usage

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 93fd1a1: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 51238c4bdbce48f6b719f7dcfe5b7df8b8c6d85b 8322503: Shenandoah: Clarify gc state usage Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@earthling-amzn
Copy link
Author

/approval request This is a follow up to JDK-8321815. It renames methods, improves comments, and adds an assert. I believe the risk is low. I also believe these GHA failures are unrelated to this change.

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@earthling-amzn
8322503: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 14, 2024
@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@earthling-amzn
Your change (at version d445df6) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

I agree GHA failures look unrelated to this PR.

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

Going to push as commit e3b6098.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 93fd1a1: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2024
@openjdk openjdk bot closed this Mar 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@shipilev @earthling-amzn Pushed as commit e3b6098.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants