-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8322503: Shenandoah: Clarify gc state usage #365
8322503: Shenandoah: Clarify gc state usage #365
Conversation
Reviewed-by: ysr, gli
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/approval request This is a follow up to JDK-8321815. It renames methods, improves comments, and adds an assert. I believe the risk is low. I also believe these GHA failures are unrelated to this change. |
@earthling-amzn |
/integrate |
@earthling-amzn |
I agree GHA failures look unrelated to this PR. /sponsor |
Going to push as commit e3b6098.
Your commit was automatically rebased without conflicts. |
@shipilev @earthling-amzn Pushed as commit e3b6098. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Resolved trivial conflicts
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/365/head:pull/365
$ git checkout pull/365
Update a local copy of the PR:
$ git checkout pull/365
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/365/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 365
View PR using the GUI difftool:
$ git pr show -t 365
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/365.diff
Webrev
Link to Webrev Comment