Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325613: CTW: Stale method cleanup requires GC after Sweeper removal #370

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 18, 2024

Clean backport to improve CTW testing times.

Additional testing:

  • Ad-hoc CTW time measurements for java.base demonstrate the same improvements as in mainline
  • Linux x86_64 server fastdebug, large CTW runs pass with this patch applied
  • MacOS AArch64 server fastdebug, applications/ctw/modules passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325613 needs maintainer approval

Issue

  • JDK-8325613: CTW: Stale method cleanup requires GC after Sweeper removal (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/370/head:pull/370
$ git checkout pull/370

Update a local copy of the PR:
$ git checkout pull/370
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 370

View PR using the GUI difftool:
$ git pr show -t 370

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/370.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@shipilev
Copy link
Member Author

/approval request Clean backport to improve CTW testing times. CTW tests pass, and much faster with the patch applied. Have been running in my CI for several days without problems. The benefit for testing time is so large I would like to have it in our dev repositories sooner. Risk is low, test only fix.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325613: CTW: Stale method cleanup requires GC after Sweeper removal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1281e18f1447848d7eb5e3bde508ac002b4c390d 8325613: CTW: Stale method cleanup requires GC after Sweeper removal Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@shipilev
8325613: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 18, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2024

Webrevs

@shipilev
Copy link
Member Author

GHA test failures are environmental.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 19, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

Going to push as commit 9e1840f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2de8cfa: 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 19, 2024
@openjdk openjdk bot closed this Mar 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@shipilev Pushed as commit 9e1840f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8325613-ctw-gc branch April 24, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant