-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8325613: CTW: Stale method cleanup requires GC after Sweeper removal #370
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
/approval request Clean backport to improve CTW testing times. CTW tests pass, and much faster with the patch applied. Have been running in my CI for several days without problems. The benefit for testing time is so large I would like to have it in our dev repositories sooner. Risk is low, test only fix. |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
GHA test failures are environmental. |
/integrate |
Clean backport to improve CTW testing times.
Additional testing:
java.base
demonstrate the same improvements as in mainlineapplications/ctw/modules
passesProgress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/370/head:pull/370
$ git checkout pull/370
Update a local copy of the PR:
$ git checkout pull/370
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/370/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 370
View PR using the GUI difftool:
$ git pr show -t 370
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/370.diff
Webrev
Link to Webrev Comment