Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326529: JFR: Test for CompilerCompile events fails due to time out #376

Conversation

roberttoyonaga
Copy link
Contributor

@roberttoyonaga roberttoyonaga commented Mar 18, 2024

This is a backport of openjdk/jdk@4dd6c44

This backport limits compilation only to the test methods TestCompileCompile cares about. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3046).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326529 needs maintainer approval

Issue

  • JDK-8326529: JFR: Test for CompilerCompile events fails due to time out (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/376/head:pull/376
$ git checkout pull/376

Update a local copy of the PR:
$ git checkout pull/376
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 376

View PR using the GUI difftool:
$ git pr show -t 376

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/376.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@roberttoyonaga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326529: JFR: Test for CompilerCompile events fails due to time out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 06e4cf3: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
  • 9e1840f: 8325613: CTW: Stale method cleanup requires GC after Sweeper removal
  • 2de8cfa: 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 8326529: JFR: Test for CompilerCompile events fails due to time out Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2024

Webrevs

@roberttoyonaga
Copy link
Contributor Author

It doesn't seem like the risc-v cross compile or the tier1 GHA test failure is related to the change here.

@roberttoyonaga
Copy link
Contributor Author

/approval request for the backport of a JFR test case fix. Should be very low risk. Clean backport.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@roberttoyonaga
8326529: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 18, 2024
@roberttoyonaga
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@roberttoyonaga
Your change (at version 0848b2b) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

Going to push as commit c8ddf40.
Since your change was applied there have been 10 commits pushed to the master branch:

  • eb4f76e: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • 196a851: 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out
  • 700fd39: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable
  • 6632caa: 8288989: Make tests not depend on the source code
  • 81f621d: 8316696: Remove the testing base classes: IntlTest and CollatorTest
  • dc6afd0: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList
  • b3e8176: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory
  • 06e4cf3: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
  • 9e1840f: 8325613: CTW: Stale method cleanup requires GC after Sweeper removal
  • 2de8cfa: 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 19, 2024
@openjdk openjdk bot closed this Mar 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@shipilev @roberttoyonaga Pushed as commit c8ddf40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants