-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line #377
Conversation
👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into |
@SoniaZaldana This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issues from the original commit. |
|
GHA Failures:
|
/integrate |
@SoniaZaldana |
/sponsor |
Going to push as commit 5694ad2.
Your commit was automatically rebased without conflicts. |
@shipilev @SoniaZaldana Pushed as commit 5694ad2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This PR contains a backport of 7004c2724d9b150112c66febb7f24b781ff379dd.
Testing:
Thanks!
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/377/head:pull/377
$ git checkout pull/377
Update a local copy of the PR:
$ git checkout pull/377
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/377/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 377
View PR using the GUI difftool:
$ git pr show -t 377
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/377.diff
Webrev
Link to Webrev Comment