Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315663: Open source misc awt tests #380

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Mar 19, 2024

I backport this for parity with 21.0.3-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315663 needs maintainer approval

Issue

  • JDK-8315663: Open source misc awt tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/380/head:pull/380
$ git checkout pull/380

Update a local copy of the PR:
$ git checkout pull/380
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/380/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 380

View PR using the GUI difftool:
$ git pr show -t 380

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/380.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315663: Open source misc awt tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 376f880: Merge
  • 07fc624: 8327391: Add SipHash attribution file
  • 6a89849: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • f17d386: 8317631: Refactor ChoiceFormat tests to use JUnit
  • 93a4707: 7001133: OutOfMemoryError by CustomMediaSizeName implementation
  • 6b0cfd4: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
  • eaa8ed9: 8324646: Avoid Class.forName in SecureRandom constructor
  • c8ddf40: 8326529: JFR: Test for CompilerCompile events fails due to time out
  • eb4f76e: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • 196a851: 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out
  • ... and 8 more: https://git.openjdk.org/jdk21u-dev/compare/d1af31b6098f4c55d05aa8693ff09f6dcc1e118a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a36f5a54ab4871739f2ccbabb684942fc3cadf20 8315663: Open source misc awt tests Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 21, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

Going to push as commit bac3b94.
Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 22, 2024
@openjdk openjdk bot closed this Mar 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@luchenlin Pushed as commit bac3b94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant