Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303891: Speed up Zip64SizeTest using a small ZIP64 file #383

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 19, 2024

I backport this for parity with 21.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8259866 needs maintainer approval
  • JDK-8303891 needs maintainer approval

Issues

  • JDK-8303891: Speed up Zip64SizeTest using a small ZIP64 file (Enhancement - P4 - Approved)
  • JDK-8259866: two java.util tests failed with "IOException: There is not enough space on the disk" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/383/head:pull/383
$ git checkout pull/383

Update a local copy of the PR:
$ git checkout pull/383
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 383

View PR using the GUI difftool:
$ git pr show -t 383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/383.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303891: Speed up Zip64SizeTest using a small ZIP64 file
8259866: two java.util tests failed with "IOException: There is not enough space on the disk"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • cc918ab: 8319048: Monitor deflation unlink phase prolongs time to safepoint
  • 376f880: Merge
  • 07fc624: 8327391: Add SipHash attribution file
  • 6a89849: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • f17d386: 8317631: Refactor ChoiceFormat tests to use JUnit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 842b895f093e15ecd8aa0153d712f5f81cf1cf67 8303891: Speed up Zip64SizeTest using a small ZIP64 file Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 20, 2024

GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated.
GHA failure Risc-V compile setup problem. Unrelated.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 21, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 21, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2024

Going to push as commit 8ecc67b.
Since your change was applied there have been 5 commits pushed to the master branch:

  • cc918ab: 8319048: Monitor deflation unlink phase prolongs time to safepoint
  • 376f880: Merge
  • 07fc624: 8327391: Add SipHash attribution file
  • 6a89849: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • f17d386: 8317631: Refactor ChoiceFormat tests to use JUnit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2024
@openjdk openjdk bot closed this Mar 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2024
@openjdk
Copy link

openjdk bot commented Mar 21, 2024

@GoeLin Pushed as commit 8ecc67b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant