Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314837: 5 compiled/codecache tests ignore VM flags #39

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 15, 2023

I backport this to keep the 21u test suite up-to-date. This will simplify future test backports.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8314837 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8314837: 5 compiled/codecache tests ignore VM flags (Sub-task - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/39/head:pull/39
$ git checkout pull/39

Update a local copy of the PR:
$ git checkout pull/39
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/39/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 39

View PR using the GUI difftool:
$ git pr show -t 39

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/39.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2a11bc41baec20cf670393ff29689043ed2d2114 8314837: 5 compiled/codecache tests ignore VM flags Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 16, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314837: 5 compiled/codecache tests ignore VM flags

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 947dfc4: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
  • dcf6eea: 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX
  • fccb0a1: 8321131: Console read line with zero out should zero out underlying buffer in JLine
  • db343c9: 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 18, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

Going to push as commit fc49ca3.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 4f17ea7: 8320383: refresh libraries cache on AIX in VMError::report
  • 947dfc4: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
  • dcf6eea: 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX
  • fccb0a1: 8321131: Console read line with zero out should zero out underlying buffer in JLine
  • db343c9: 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2023
@openjdk openjdk bot closed this Dec 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@GoeLin Pushed as commit fc49ca3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant